Fix emphasis followed by a punctuation #1383
Merged
+26
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UziTech
reviewed
Dec 5, 2018
UziTech
requested changes
Dec 5, 2018
Member
UziTech
left a comment
UziTech
left a comment
There was a problem hiding this comment.
looks good to me if all the tests pass
Co-Authored-By: RomanGotsiy <[email protected]>
Member
|
@RomanGotsiy you can add a test in https://github.com/markedjs/marked/blob/master/test/specs/marked/marked.json |
Contributor
Author
|
@UziTech Added a few extra tests and fixed lint issue. |
UziTech
approved these changes
Dec 5, 2018
styfle
changed the title
RomanHotsiy
pushed a commit
to Redocly/redoc
that referenced
this pull request
Jan 17, 2019
The new release includes markedjs/marked#1383.
This was referenced Aug 30, 2019
This was referenced Oct 26, 2019
This was referenced Nov 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version:
0.5.2
Markdown flavor: CommonMark
Description
My previous PR #1351 caused a regression for some emphasis use cases. There is no specific CommonMark test to catch that. @styfle could you suggest me where to put the test for this specific use case so it won't break in the future?
Contributor
Committer
In most cases, this should be a different person than the contributor.