ecdsa: make SignPrimitive's ephemeral scalar generic #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and remove masking scalar. This API allows the inversion masking process to be handled outside of the ECDSA implementation itself (potentially generically in a way that can work across elliptic curves).
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
=======================================
Coverage 53.59% 53.59%
=======================================
Files 3 3
Lines 181 181
=======================================
Hits 97 97
Misses 84 84 Continue to review full report at Codecov.
|
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Jul 28, 2020
Updates both crates with the `SignPrimitive` changes from RustCrypto/signatures#107. These changes removed the `masking_scalar` from the trait, and replaced it with trait bounds that make it possible to substitute a blinded scalar. In the `p256` crate (which is the only one that presently implements a variable-time inversion) the `masking_scalar` is replaced with a `BlindedScalar` type that implements the previous blinded inversion. The implementation it uses (including `Scalar::invert_vartime`) could potentially be made generic and extracted into the `elliptic-curve` crate, allowing it to be used with any curve which implements the arithmetic primitives used in the blinded inversion implementation. However, for now, this PR leaves it in `p256`, and therefore at least has feature parity with the old implementation.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Jul 28, 2020
Updates both crates with the `SignPrimitive` changes from RustCrypto/signatures#107. These changes removed the `masking_scalar` from the trait, and replaced it with trait bounds that make it possible to substitute a blinded scalar. In the `p256` crate (which is the only one that presently implements a variable-time inversion) the `masking_scalar` is replaced with a `BlindedScalar` type that implements the previous blinded inversion. The implementation it uses (including `Scalar::invert_vartime`) could potentially be made generic and extracted into the `elliptic-curve` crate, allowing it to be used with any curve which implements the arithmetic primitives used in the blinded inversion implementation. However, for now, this PR leaves it in `p256`, and therefore at least has feature parity with the old implementation.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Jul 28, 2020
Updates both crates with the `SignPrimitive` changes from RustCrypto/signatures#107. These changes removed the `masking_scalar` from the trait, and replaced it with trait bounds that make it possible to substitute a blinded scalar. In the `p256` crate (which is the only one that presently implements a variable-time inversion) the `masking_scalar` is replaced with a `BlindedScalar` type that implements the previous blinded inversion. The implementation it uses (including `Scalar::invert_vartime`) could potentially be made generic and extracted into the `elliptic-curve` crate, allowing it to be used with any curve which implements the arithmetic primitives used in the blinded inversion implementation. However, for now, this PR leaves it in `p256`, and therefore at least has feature parity with the old implementation.
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Jul 28, 2020
Updates both crates with the `SignPrimitive` changes from RustCrypto/signatures#107. These changes removed the `masking_scalar` from the trait, and replaced it with trait bounds that make it possible to substitute a blinded scalar. In the `p256` crate (which is the only one that presently implements a variable-time inversion) the `masking_scalar` is replaced with a `BlindedScalar` type that implements the previous blinded inversion. The implementation it uses (including `Scalar::invert_vartime`) could potentially be made generic and extracted into the `elliptic-curve` crate, allowing it to be used with any curve which implements the arithmetic primitives used in the blinded inversion implementation. However, for now, this PR leaves it in `p256`, and therefore at least has feature parity with the old implementation.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and remove
masking_scalar.This API allows the inversion masking process to be handled outside of the ECDSA implementation itself (potentially generically in a way that can work across elliptic curves).