Skip to content

ecdsa: make SignPrimitive's ephemeral scalar generic #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 1 commit into from
Jul 28, 2020
Merged

ecdsa: make SignPrimitive's ephemeral scalar generic #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions ecdsa/src/hazmat.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
//! FULL PRIVATE KEY RECOVERY!

use crate::{Signature, SignatureSize};
use elliptic_curve::{generic_array::ArrayLength, weierstrass::Curve, Arithmetic, ScalarBytes};
use elliptic_curve::{
generic_array::ArrayLength, ops::Invert, weierstrass::Curve, Arithmetic, ScalarBytes,
};
use signature::Error;

#[cfg(feature = "digest")]
Expand All @@ -33,12 +35,10 @@ where
/// Accepts the following arguments:
///
/// - `ephemeral_scalar`: ECDSA `k` value (MUST BE UNIFORMLY RANDOM!!!)
/// - `masking_scalar`: optional blinding factor for sidechannel resistance
/// - `hashed_msg`: prehashed message to be signed
fn try_sign_prehashed(
fn try_sign_prehashed<K: Into<C::Scalar> + Invert<Output = C::Scalar>>(
&self,
ephemeral_scalar: &C::Scalar,
masking_scalar: Option<&C::Scalar>,
ephemeral_scalar: &K,
hashed_msg: &ScalarBytes<C>,
) -> Result<Signature<C>, Error>;
}
Expand Down