Skip to content

Conversation

yewalenikhil65
Copy link
Contributor

@yewalenikhil65 yewalenikhil65 commented Sep 2, 2021

from #390

based on defintions of linkageclasses
and deficiency

API  functions for linkageclasses and deficiency
updating comment descriptions of newly added funcs `incidencematgraph` , `linkageclasses` and `deficiency`
dependencies and exporting funcs
adding tests for `linkageclasses` and `deficiency`
missing qualifier AbstractAlgebra.matrix
fixing as per suggestions
updating test lines for `deficiency`
@yewalenikhil65
Copy link
Contributor Author

Thanks @isaacsas
Looks good now.
Next stop of network analysis should be about weakly reversible networks, and summarize functions that you were talking about. And somewhere we could fit deficiency theorems in all this.

@yewalenikhil65 yewalenikhil65 changed the title linkageclasses and deficiency of reaction network [WIP] linkageclasses and deficiency of reaction network Sep 6, 2021
@isaacsas
Copy link
Member

isaacsas commented Sep 6, 2021

@yewalenikhil65 made some modifications. In particular, I think deficiency requires enough inputs that it is better to expect users to pass the correct stuff, but make sure the docs show how to do this for an example (which I added). Having sparse in it just felt wrong, and it was getting too complicated in all the stuff it was sequentially calculating as kwargs.

@isaacsas isaacsas merged commit ea5dd89 into SciML:master Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants