Use wrapper methods to remove duplicated code #116
Conversation
-Fix some File.equals(someString) that always returned false.
-Use Boolean.toString()
-Create a wrapper method (getBuildEnvironmentVariableBoolean) that converts values to boolean from the getBuildEnvironmentVariable method.
-Create a wrapper method (getBuildEnvironmentVariable) that uses empty string as default value.
-Use new methods to reduce code size.
There was a problem hiding this comment.
Any reason why you changed the warning to an error?
There was a problem hiding this comment.
Oops, it's a mistake. Maybe I got confused by the message.
There is an option on github to modify the pull request?
El 24/12/13 18:57, jantje escribió:
In it.baeyens.arduino.common/src/it/baeyens/arduino/arduino/Serial.java:
@@ -62,7 +59,7 @@
* General error reporting, all correlated here just in case I think of something slightly more intelligent to do.
*/
static public void errorMessage(String where, Throwable e) {
- Common.log(new Status(IStatus.WARNING, ArduinoConst.CORE_PLUGIN_ID, "Error inside Serial. " + where, e));
- Common.logError("Error inside Serial. " + where, e);
Any reason why you changed the warning to an error?
—
Reply to this email directly or view it on GitHub
https://github.com/jantje/arduino-eclipse-plugin/pull/116/files#r8545373.
There was a problem hiding this comment.
There is an option on github to modify the pull request?
I don't know. I never made an accepted pull request in github
|
In a few days I will fix all issues/bugs commented and open another pull request. |
|
I've gone through the whole lot so I guess that is it. |
2 participants
-Added methods logError, logWarn, logInfo to avoid using log(new Status(...))
-Added getBuildEnvironmentVariableBoolean() that returns the boolean value instead of String.
-Use that methods to remove duplicate code.