Skip to content

Use wrapper methods to remove duplicated code #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amorellgarcia wants to merge 6 commits into from
Closed

Use wrapper methods to remove duplicated code #116

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3c08017
-Replace String.equals("") with String.isEmpty().
amorellgarcia Dec 24, 2013
fd0542b
-Move "true" and "false" strings to ArduinoConst.TRUE|FALSE
amorellgarcia Dec 24, 2013
b3fb608
-Create "true" and "false string constants in ArduinoConst
amorellgarcia Dec 24, 2013
f5b64b9
-New empty string constant ("") in ArduinoConst.
amorellgarcia Dec 24, 2013
ec300a4
-Add logError, logWarn and logInfo to class Common.
amorellgarcia Dec 24, 2013
2147c52
Remove unused imports.
amorellgarcia Dec 24, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove unused imports.
  • Loading branch information
@amorellgarcia
amorellgarcia committed Dec 24, 2013
commit 2147c52c0962992b83490db789052ef03ad2b4c4
3 changes: 0 additions & 3 deletions it.baeyens.arduino.core/src/it/baeyens/arduino/actions/AddSourceFolderAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package it.baeyens.arduino.actions;

import it.baeyens.arduino.common.ArduinoConst;
import it.baeyens.arduino.common.ArduinoInstancePreferences;
import it.baeyens.arduino.common.Common;

Expand All @@ -9,8 +8,6 @@
import org.eclipse.core.commands.ExecutionException;
import org.eclipse.core.resources.IProject;
import org.eclipse.core.runtime.CoreException;
import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.Status;
import org.eclipse.jface.wizard.IWizard;
import org.eclipse.jface.wizard.WizardDialog;
import org.eclipse.ui.PlatformUI;
Expand Down
3 changes: 0 additions & 3 deletions it.baeyens.arduino.core/src/it/baeyens/arduino/actions/ArduinoUploadProjectHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package it.baeyens.arduino.actions;

import it.baeyens.arduino.common.ArduinoConst;
import it.baeyens.arduino.common.ArduinoInstancePreferences;
import it.baeyens.arduino.common.Common;
import it.baeyens.arduino.tools.uploaders.UploadSketchWrapper;
Expand All @@ -10,8 +9,6 @@
import org.eclipse.core.commands.ExecutionEvent;
import org.eclipse.core.commands.ExecutionException;
import org.eclipse.core.resources.IProject;
import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.Status;

/**
* This is a handler to connect the plugin.xml to the code for uploading code to arduino teensy ..
Expand Down
3 changes: 1 addition & 2 deletions it.baeyens.arduino.core/src/it/baeyens/arduino/communication/ArduinoSerial.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@
import java.util.Vector;

import org.eclipse.core.resources.IProject;
import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.Status;


public class ArduinoSerial {
/**
Expand Down
3 changes: 1 addition & 2 deletions it.baeyens.arduino.core/src/it/baeyens/arduino/toolchain/hexNameProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@
import org.eclipse.cdt.managedbuilder.core.ITool;
import org.eclipse.core.resources.IProject;
import org.eclipse.core.runtime.IPath;
import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.Path;
import org.eclipse.core.runtime.Status;


public class hexNameProvider implements IManagedOutputNameProviderJaba {

Expand Down
2 changes: 0 additions & 2 deletions it.baeyens.arduino.core/src/it/baeyens/arduino/tools/ArduinoHelpers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,9 @@
import org.eclipse.core.runtime.CoreException;
import org.eclipse.core.runtime.IPath;
import org.eclipse.core.runtime.IProgressMonitor;
import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.NullProgressMonitor;
import org.eclipse.core.runtime.Path;
import org.eclipse.core.runtime.Platform;
import org.eclipse.core.runtime.Status;
import org.eclipse.ui.console.ConsolePlugin;
import org.eclipse.ui.console.IConsole;
import org.eclipse.ui.console.IConsoleManager;
Expand Down
2 changes: 0 additions & 2 deletions it.baeyens.arduino.core/src/it/baeyens/arduino/ui/ArduinoSelectionPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@
import org.eclipse.core.resources.IProject;
import org.eclipse.core.runtime.CoreException;
import org.eclipse.core.runtime.IPath;
import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.Path;
import org.eclipse.core.runtime.Status;
import org.eclipse.jface.dialogs.Dialog;
import org.eclipse.swt.SWT;
import org.eclipse.swt.layout.GridData;
Expand Down
2 changes: 0 additions & 2 deletions it.baeyens.arduino.core/src/it/baeyens/arduino/ui/Import_Arduino_Libraries_Page.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
import org.eclipse.core.resources.IProject;
import org.eclipse.core.runtime.CoreException;
import org.eclipse.core.runtime.IPath;
import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.Status;
import org.eclipse.jface.viewers.IStructuredSelection;
import org.eclipse.jface.viewers.ITreeContentProvider;
import org.eclipse.swt.SWT;
Expand Down
2 changes: 0 additions & 2 deletions it.baeyens.arduino.core/src/it/baeyens/arduino/ui/NewArduinoSketchWizard.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,8 @@
import org.eclipse.core.runtime.IExecutableExtension;
import org.eclipse.core.runtime.IPath;
import org.eclipse.core.runtime.IProgressMonitor;
import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.OperationCanceledException;
import org.eclipse.core.runtime.Path;
import org.eclipse.core.runtime.Status;
import org.eclipse.core.runtime.SubProgressMonitor;
import org.eclipse.jface.dialogs.MessageDialog;
import org.eclipse.jface.viewers.IStructuredSelection;
Expand Down
2 changes: 0 additions & 2 deletions it.baeyens.arduino.monitor/src/it/baeyens/arduino/monitor/views/ScopeListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@

import multichannel.Oscilloscope;

import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.Status;
import org.eclipse.swt.widgets.Display;

public class ScopeListener implements MessageConsumer {
Expand Down
2 changes: 0 additions & 2 deletions it.baeyens.arduino.monitor/src/it/baeyens/arduino/monitor/views/SerialListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
import java.nio.ByteBuffer;
import java.nio.ByteOrder;

import org.eclipse.core.runtime.IStatus;
import org.eclipse.core.runtime.Status;
import org.eclipse.swt.widgets.Display;

public class SerialListener implements MessageConsumer {
Expand Down