Merge upstream changes #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move m_key member of Effect into Plugin * Pass key to Instrument ctors and instantiaters * Add pluginKeys to all plugin selector widgets, and let them pass the keys when instantiating the instruments; or, if the keys must be passed over threads, pass the keys to the Engine using `Engine::setDndPluginKey()` * As instrument plugin libraries now also need to get their key passed, their second argument, which was always the same as the first, is now used to pass the sub plugin keys. This affects *all* instrument plugins. * Plugin.h: Add more virtuals to `SubPluginFeatures` in order to draw logos and images into instrument selector widgets * LadspaSubPluginFeatures: Implement the `displayName` virtual because the new behaviour to resolve displayNames is to first look at the SubPluginFeatures, which, without override, returns the superior plugin's name (Plugin.cpp) Additional: * PluginFactory.h: Allow setting up search paths without discovering plugins yet * Plugin.h: Add full documentation (should be checked)
The former virtuals returned `const char*`, which lead to invalid reads when `LadspaSubPluginFeatures` returned pointers to temporary `QByteArray::data`.
Tests whether contributions break packaging inadvertently
Fix insert bars, delete bars, delete notes on Apple keyboard
Compilation fails with debug build. Fixes regression from dd99f3a
Fix the build of MixHelpers.cpp which fails due to a missing include of cstdio (printf is not defined).
Temporarily disable soundio on macOS to address stability issues with PortAudio Closes #4864
* Sync Debian version * Drop temporary logging
Fix a regression in #4797
Fix another regression in #4797
* Fix uninitialized m_jackClient being used in MidiJack destructor * Fix destruction order in Mixer.cpp so that MidiJack doesn't access the deleted AudioJack instance Fixes #4688
Fix a crash that occurred on the following steps: 1. Add an AFP track. 2. Open it, and move the waveform display to overlap the track label button. 3. Close the AFP window and open it again by clicking the track label. 4. Move the mouse pointer. The problem occurs because the code makes the implicit assumption that AudioFileProcessorWaveView::enterEvent (and hence QApplication::setOverrideCursor) is called before AudioFileProcessorWaveView::mouseMoveEvent. This is not the case when the waveform display is on top of the track label. In this case the AFP windows is opened with the mouse being immediately positioned over the wave form display. There is no enter event and move events are issues directly. This then leads to a crash in AudioFileProcessorWaveView::mouseMoveEvent when trying to determine the value for is_size_cursor because the override cursor is still null but is dereferenced directly without checking. Only adding a check would not solve the problem because in that case the cursor would not change to the hand cursor when being moved inside the waveform display. The solution is to remove all calls to the global methods setOverrideCursor and restoreOverrideCursor and to only set the cursor locally. This fix is based on a patch by gi0e5b06 which is committed under 8a10c52 in his repository but for which he never created a pull request.
It was wrongly done in 231a840.
It's LMMS specific now
* Support more Wine packagings * Allow building 64-bit RemoteVstPlugin using 32-bit Wine tools if possible * Provide suitable library paths for creating AppImages
…ly supports Note that the additional -unsupported-allow-new-glibc switch may result in an AppImage which is unusable on old systems.
Add `override` keyword
SampleBuffer was using baseSampleRate as the default samplerate instead of the actual processingSampleRate.
played correctly after saving and loading a project due to sample rate not getting saved in the project file.
right place when it not played from the begining. That has created a difference between the ticks and the metronome and the sample track. The cause of the problem was that the calculation of the frame to play was wrong: we had calculated `framesPerTick` according to the current engine's sample rate instead of the SampleBuffer's sample rate.
appdmg recently dropped support for Node.js < 8.5
Fixes wrongly set 'Blues' genre(ID 0) in exported mp3 files.
Co-Authored-By: Hyunjin Song <[email protected]>
* Fix "Export Tracks" * Add "Export MIDI" [ci skip]
Rebrand macOS DMG background - Design and artwork courtesy @RebeccaDeField - Closes #4289
* Song: add isSavingProject. * VersionedSaveDialog: Add support for a custom option dialog. * AutomatableModel: Support the discardMIDIConnections save option. * InstrumentTrack: Support the discardMIDIConnections save option. * SaveOptions: Show the save option dialog on "save as".
# Conflicts: # data/locale/cs.ts # data/locale/en.ts # data/locale/ko.ts # data/locale/ru.ts # data/locale/uk.ts # data/locale/zh_TW.ts # include/Engine.h # plugins/nes/Nes.cpp # src/core/NotePlayHandle.cpp # src/core/SampleBuffer.cpp # src/tracks/SampleTrack.cpp
This also fixes a display bug that is present with large fader falloff speeds.
* Replace tLimit() with qBound() * Remove templates.h
Increase Mixer fader falloff speed
This file tells the github online editor to use tabs of width 4 instead of 8. Open [this](https://github.com/JohannesLorenz/github_test/blob/master/test.cpp) test file in your browser to see how it works (the width is 5 in the example). Actually, it also tells many other editors...
* implements drag and drop samples to sampletracks * clean up / take care of timeLineWidget heigth in songeditor * unused memeber removed * clean up * Update include/TrackContainerView.h Co-Authored-By: Spekular <[email protected]> * Update src/gui/TrackContainerView.cpp Co-Authored-By: Spekular <[email protected]> * Update src/gui/TrackContainerView.cpp Co-Authored-By: Spekular <[email protected]> * Update src/gui/editors/SongEditor.cpp Co-Authored-By: Spekular <[email protected]> * load AFP if we don't drop on a sample track * take care of timeLineWidget size changes * clean up * consolidate some code * requested changes by code review * move logic to SampleTrackView * clean up * clean up * clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.