Skip to content

Prefer official VTK package, fallback to ours #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BryanRumsey merged 4 commits into from
Apr 14, 2021
Merged

Prefer official VTK package, fallback to ours #98

BryanRumsey merged 4 commits into from
Apr 14, 2021

Conversation

@makdl
Copy link
Contributor

@makdl makdl commented Mar 15, 2021 •
edited
Loading

Changes:

  • The official KitWare VTK package is preferred over our own custom VTK polydata reader. Our reader will only be used as a fallback if the KitWare package is not able to imported.
  • Added docstring to read_step()

Why:
Our reader is significantly slower than the KitWare package.

BryanRumsey
BryanRumsey reviewed Mar 30, 2021
View reviewed changes
@BryanRumsey BryanRumsey merged commit 2cf3165 into develop Apr 14, 2021
@makdl makdl deleted the prefer_official_vtk branch April 15, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BryanRumsey BryanRumsey BryanRumsey approved these changes

@briandrawert briandrawert Awaiting requested review from briandrawert

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@makdl @briandrawert @BryanRumsey