Skip to content

Prefer official VTK package, fallback to ours #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BryanRumsey merged 4 commits into from
Apr 14, 2021
Merged

Prefer official VTK package, fallback to ours #98

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2aa0f5c
Prefer official VTK package, fallback to ours
makdl Mar 15, 2021
7012fe2
Fixed except, typos, and message
makdl Apr 13, 2021
c90de05
Revert "Fixed except, typos, and message"
makdl Apr 13, 2021
700844b
Fixed except, and message, this time without a conflict
makdl Apr 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Fixed except, typos, and message" 
This reverts commit 7012fe2.
  • Loading branch information
@makdl
makdl committed Apr 13, 2021
commit c90de0597efe8f3b286a5736bc2ff69f5f2c636b
2 changes: 1 addition & 1 deletion spatialpy/Mesh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ def read_msh_file(cls, filename):
try:
import meshio
except ImportError as e:
raise MeshError("The Python package 'meshio' is not installed.")
raise MeshError("The python package 'meshio' is not istaled.")

return cls.import_meshio_object(meshio.msh_io.read(filename))

Expand Down
5 changes: 3 additions & 2 deletions spatialpy/Result.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@

try:
import vtk
except ImportError as e:
print('''The Python package 'vtk' is not installed. Using integrated VTK reader. This is significantly slower than the official VTK package.''')
except:
print('''Using fallback VTK reader. This is significantly slower than the official VTK package.
For best performance please install the VTK Python package: \'python3 -m pip install vtk\'''')
from spatialpy.VTKReader import VTKReader

common_rgb_values=['#1f77b4','#ff7f0e','#2ca02c','#d62728','#9467bd','#8c564b','#e377c2','#7f7f7f',
Expand Down