Skip to content

fix: MockFileSystem's File.WriteAllText, File.ReadAllText, Directory.GetFiles, Directory.Create fail with \\?\C:\foo style paths #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbreuss merged 6 commits into from
Jul 8, 2025
Merged

fix: MockFileSystem's File.WriteAllText, File.ReadAllText, Directory.GetFiles, Directory.Create fail with \\?\C:\foo style paths #1305

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
87630ba
Test that MockDirectory.CreateDirectory supports windows extended-len…
mostynb Jul 1, 2025
b9d59a2
Make MockDirectory_CreateDirectory_ShouldSupportExtendedLengthPaths pass
mostynb Jul 4, 2025
264f1e0
Also test that MockDirectory.CreateDirectory with an extended path re…
mostynb Jul 6, 2025
0918171
Make MockFileSystem's File.WriteAllText, File.ReadAllText and Directo…
mostynb Jul 6, 2025
b848a72
Merge branch 'main' into path_verifier_extended_length_paths
vbreuss Jul 6, 2025
01e274a
Refactor a little
mostynb Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make MockFileSystem's File.WriteAllText, File.ReadAllText and Directo… 
…ry.GetFiles support extended length paths too
  • Loading branch information
@mostynb
mostynb committed Jul 6, 2025
commit 0918171f91fb85fd3ea9c7e2a7e52096ee4d1c0f
6 changes: 6 additions & 0 deletions src/TestableIO.System.IO.Abstractions.TestingHelpers/PathVerifier.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,12 @@ public void IsLegalAbsoluteOrRelative(string path, string paramName)

private static bool IsValidUseOfVolumeSeparatorChar(string path)
{
const string EXTENDED_LENGTH_PATH_PREFIX = @"\\?\";
if (path.StartsWith(EXTENDED_LENGTH_PATH_PREFIX))
{
path = path.Substring(EXTENDED_LENGTH_PATH_PREFIX.Length);
}

var lastVolSepIndex = path.LastIndexOf(Path.VolumeSeparatorChar);
return lastVolSepIndex == -1 || lastVolSepIndex == 1 && char.IsLetter(path[0]);
}
Expand Down
4 changes: 4 additions & 0 deletions tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockDirectoryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,10 +756,14 @@ public async Task MockDirectory_CreateDirectory_ShouldSupportExtendedLengthPaths

// Act
var directoryInfo = fileSystem.Directory.CreateDirectory(XFS.Path(@"\\?\c:\bar"));
fileSystem.File.WriteAllText(@"\\?\c:\bar\grok.txt", "hello world\n");

// Assert
await That(fileSystem.Directory.Exists(XFS.Path(@"\\?\c:\bar"))).IsTrue();
await That(directoryInfo.FullName).IsEqualTo(@"\\?\c:\bar");
await That(fileSystem.File.ReadAllText(@"\\?\c:\bar\grok.txt")).IsEqualTo("hello world\n");
await That(fileSystem.Directory.GetFiles(@"\\?\c:\bar")).HasSingle()
.Which.IsEqualTo(@"\\?\c:\bar\grok.txt");
}

// Issue #210
Expand Down