Skip to content

fix: MockFileSystem's File.WriteAllText, File.ReadAllText, Directory.GetFiles, Directory.Create fail with \\?\C:\foo style paths #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbreuss merged 6 commits into from
Jul 8, 2025
Merged

fix: MockFileSystem's File.WriteAllText, File.ReadAllText, Directory.GetFiles, Directory.Create fail with \\?\C:\foo style paths #1305

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
87630ba
Test that MockDirectory.CreateDirectory supports windows extended-len…
mostynb Jul 1, 2025
b9d59a2
Make MockDirectory_CreateDirectory_ShouldSupportExtendedLengthPaths pass
mostynb Jul 4, 2025
264f1e0
Also test that MockDirectory.CreateDirectory with an extended path re…
mostynb Jul 6, 2025
0918171
Make MockFileSystem's File.WriteAllText, File.ReadAllText and Directo…
mostynb Jul 6, 2025
b848a72
Merge branch 'main' into path_verifier_extended_length_paths
vbreuss Jul 6, 2025
01e274a
Refactor a little
mostynb Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make MockDirectory_CreateDirectory_ShouldSupportExtendedLengthPaths pass 
Fixes #1304
  • Loading branch information
@mostynb
mostynb committed Jul 4, 2025
commit b9d59a2579bf533ec7099a799f0bf16d91e37238
15 changes: 13 additions & 2 deletions src/TestableIO.System.IO.Abstractions.TestingHelpers/PathVerifier.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System.Linq;
using System;
using System.Linq;

namespace System.IO.Abstractions.TestingHelpers;

Expand Down Expand Up @@ -97,6 +98,16 @@ public bool HasIllegalCharacters(string path, bool checkAdditional)

if (checkAdditional)
{
// AdditionalInvalidPathChars includes '?', but this character is allowed in extended-length
// windows path prefixes (`\\?\`). If we're dealing with such a path, check for invalid
// characters after the prefix.
// Ref: https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry
const string EXTENDED_LENGTH_PATH_PREFIX = @"\\?\";
if (XFS.IsWindowsPlatform() && path.StartsWith(EXTENDED_LENGTH_PATH_PREFIX))
{
path = path.Substring(EXTENDED_LENGTH_PATH_PREFIX.Length);
}

return path.IndexOfAny(invalidPathChars.Concat(AdditionalInvalidPathChars).ToArray()) >= 0;
}

Expand Down Expand Up @@ -164,4 +175,4 @@ public bool TryNormalizeDriveName(string name, out string result)
result = name;
return true;
}
}
}