Add default_columns classmethod to Progress class#1894
Merged
willmcgugan merged 2 commits intoTextualize:masterfrom Feb 4, 2022
Merged
Add default_columns classmethod to Progress class#1894willmcgugan merged 2 commits intoTextualize:masterfrom
willmcgugan merged 2 commits intoTextualize:masterfrom
Conversation
willmcgugan
requested changes
Jan 31, 2022
Member
willmcgugan
left a comment
willmcgugan
left a comment
There was a problem hiding this comment.
Great! Just a request for name and docstring.
Codecov Report
@@ Coverage Diff @@
## master #1894 +/- ##
==========================================
- Coverage 99.82% 99.80% -0.03%
==========================================
Files 71 71
Lines 6943 7035 +92
==========================================
+ Hits 6931 7021 +90
- Misses 12 14 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Contributor
Author
|
This should be ready whenever you are. Unless you have further comments, I'll assume this is in your queue for the next release. |
Member
|
Thanks! |
This was referenced Feb 8, 2022
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Feb 21, 2022
11.2.0 Added Add support for US spelling of "gray" in ANSI color names Textualize/rich#1890 Added rich.diagnose.report to expose environment debugging logic as function Textualize/rich#1917 Added classmethod Progress.get_default_columns() to get the default list of progress bar columns Textualize/rich#1894 Fixed Fixed performance issue in measuring text Fixed test failures on PyPy3 Textualize/rich#1904
This was referenced Mar 7, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
Added new default_columns() classmethod to the Progress class, so that client code does not need to replicate the defaults literally, but can just add
*Progress.default_columns()