Skip to content

PyPy3 test fixes#1904

Merged
willmcgugan merged 2 commits intoTextualize:masterfrom
mgorny:lexer-name-fix
Feb 9, 2022
Merged

PyPy3 test fixes#1904
willmcgugan merged 2 commits intoTextualize:masterfrom
mgorny:lexer-name-fix

Conversation

@mgorny
Copy link
Contributor

@mgorny mgorny commented Feb 1, 2022 •
edited
Loading

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

  1. Fix test_syntax to compare strings via == rather than is, in order to fix test failure on PyPy3.
  2. Skip a few test_inspect tests on PyPy3 that fail due to different output.

@mgorny
Fix test_syntax not to use identity comparison on string
8e3a0be 
Fix test_syntax to compare strings via "==" rather than "is", in order
to fix test failure on PyPy3.
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2022 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.80%. Comparing base (e839bfb) to head (f15dc3e).
Report is 1543 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1904      +/-   ##
==========================================
- Coverage   99.82%   99.80%   -0.03%     
==========================================
  Files          71       71              
  Lines        6943     7032      +89     
==========================================
+ Hits         6931     7018      +87     
- Misses         12       14       +2
Flag Coverage Δ
unittests 99.80% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgorny mgorny changed the title Fix test_syntax not to use identity comparison on string PyPy3 test fixes Feb 1, 2022
@mgorny
Fix test_inspect failures on PyPy3
f15dc3e 
Mark the test_inspect tests failing on PyPy3 due to different output
to be skipped appropriately.
@mgorny
Copy link
Contributor Author

mgorny commented Feb 9, 2022

Ping.

@willmcgugan
Copy link
Member

willmcgugan commented Feb 9, 2022

Thanks.

@willmcgugan willmcgugan merged commit 5fafb92 into Textualize:master Feb 9, 2022
This was referenced Feb 9, 2022
Closed
Closed
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Feb 21, 2022
py-rich: updated to 11.2.0
ca8134e 
11.2.0

Added

Add support for US spelling of "gray" in ANSI color names Textualize/rich#1890
Added rich.diagnose.report to expose environment debugging logic as function Textualize/rich#1917
Added classmethod Progress.get_default_columns() to get the default list of progress bar columns Textualize/rich#1894

Fixed

Fixed performance issue in measuring text
Fixed test failures on PyPy3 Textualize/rich#1904
This was referenced Mar 7, 2022
Closed
Merged
Closed
Closed
Merged
@renovate renovate bot mentioned this pull request Mar 26, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgorny @codecov-commenter @willmcgugan