Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
6633d17
fix(node): bound REST blob reads
Sep 7, 2026
95d295c
test(node): cover blob authorization denials.
Sep 7, 2026
d824cfa
fix(node): Hide Git diagnostics from blob error responses.
Sep 9, 2026
3d7032b
fix(node): close REST blob admission and error gaps
Sep 9, 2026
fc2d043
fix(node): acquire blob permits pre-DB and cover route/fallback arms
Sep 10, 2026
c63527c
fix(node): confirm blob absence against a readable store
Sep 12, 2026
8977ed4
fix(node): bound REST blob response delivery
Sep 12, 2026
e1fe66e
test(git): distinguish every bounded ref fallback
Sep 12, 2026
4344b77
docs(node): describe the cat-file blob read path
Sep 12, 2026
49aebb2
fix(node): prevent caching of authorized blob content
Sep 12, 2026
c566455
fix(node): pin non-blob denial and map unreadable store to 503
Sep 12, 2026
df5a283
style(repos): simplify blob semaphore permit assertion for clippy
Sep 13, 2026
f0d0025
fix(git): classify unreadable store with ProbeError and tighten blob …
Sep 13, 2026
eb1222d
test(node): assert full blob admission release after read errors
Sep 14, 2026
c15acf5
test(git): require probe completion before reprobe budget denial
Sep 14, 2026
77e9b76
test(node): make Windows regression fixtures portable
Sep 14, 2026
5d238ca
fix(sync): use a supported Windows promisor blob filter
Sep 14, 2026
2c7f60a
test(git): route write-then-exec fixtures through write_blob_probe_fi…
Sep 15, 2026
2bb398e
test(sync): assert configured partialclonefilter and pin platform con…
Sep 15, 2026
bbab52e
test(api,git): close write-fd window in exec'd fixtures
Sep 17, 2026
ad003b3
fix(api): clamp authorize_repo_read with acquire timeout in get_blob
Sep 18, 2026
a2c996a
docs(config): describe the blob authorization deadline
Sep 20, 2026
5f588c1
test(api): bound the blob authorization timeout regression
Sep 20, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs(config): describe the blob authorization deadline
Document that the acquisition timeout independently bounds PostgreSQL
authorization for REST blob reads, so operators can account for both waits.

Refs #204
  • Loading branch information
euxaristia
euxaristia committed Sep 20, 2026
commit a2c996a538e52f85db59798956d19f96afce4aae
12 changes: 7 additions & 5 deletions .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -132,11 +132,13 @@ GITLAWB_MAX_PACK_BYTES=2147483648
GITLAWB_GIT_SERVICE_TIMEOUT_SECS=600

# Max seconds the storage-ACQUISITION phase of a served git op may run before the
# request is shed with a 503, separate from the git-run timeout above. A
# concurrency permit is taken before this phase and GITLAWB_GIT_SERVICE_TIMEOUT_SECS
# only starts once git spawns, so without this a stalled backend (a hung Tigris
# HEAD/GET, or a hung pg advisory-lock iteration on push) pins the permit and drains
# the pool until every later request 503s. On expiry the permit is released
# request is shed with a 503, separate from the git-run timeout above. Each
# REST blob read also applies this deadline independently to its preceding
# PostgreSQL authorization wait. A concurrency permit is taken before this phase
# and GITLAWB_GIT_SERVICE_TIMEOUT_SECS only starts once git spawns, so without
# this a stalled backend (a hung Tigris HEAD/GET, or a hung pg advisory-lock
# iteration on push) pins the permit and drains the pool until every later
# request 503s. On expiry the permit is released
# (fail-closed). Kept separate because acquisition and git execution are distinct
# cost centers. Must be positive; set very large to effectively disable. Default 30.
GITLAWB_GIT_ACQUIRE_TIMEOUT_SECS=30
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ Important node settings:
| `GITLAWB_AUTO_SYNC` | Enable automatic sync from known peers. |
| `GITLAWB_MAX_PACK_BYTES` | Max git pack body size for smart-HTTP routes. |
| `GITLAWB_GIT_SERVICE_TIMEOUT_SECS` | Max seconds a served git upload-pack, receive-pack, `info/refs` advertisement, or REST blob read may run before it is aborted (504). Default 600. Also bounds the withheld-blob classification walk (on both the upload-pack serve and receive-pack replication paths) and the push-side pin-candidate discovery (`rev-list` / `cat-file`), each reaped via process-group teardown at the deadline. On the path-scoped upload-pack path the classification walk and the pack serve share ONE deadline, so this value bounds their combined duration rather than granting each stage a full budget: a walk that consumes it leaves the serve nothing and the clone gets a 504. Serving large path-scoped repos may therefore need a higher value than they did when each stage was budgeted separately. Accepted range is 1 to 3153600000 (100 years), since the node derives deadlines from this value and a larger one cannot be represented. |
| `GITLAWB_GIT_ACQUIRE_TIMEOUT_SECS` | Max seconds the storage-acquisition phase (Tigris HEAD/GET, push advisory-lock) of a served git op may run before the request is shed with a 503, separate from the git-run timeout. The concurrency permit is released on expiry so a stalled backend cannot pin the pool. Default 30. |
| `GITLAWB_GIT_ACQUIRE_TIMEOUT_SECS` | Max seconds the storage-acquisition phase (Tigris HEAD/GET, push advisory-lock) of a served git op may run before the request is shed with a 503, separate from the git-run timeout. REST blob reads also apply this deadline independently to the preceding PostgreSQL authorization wait. The concurrency permit is released on expiry so a stalled backend cannot pin the pool. Default 30. |
| `GITLAWB_MAX_CONCURRENT_GIT_OPS` | Max concurrent served git READ ops (upload-pack, its `info/refs` advertisement, and REST blob reads) across all callers; over-cap sheds a 503 + Retry-After. Anonymous reads draw from this pool, so pair it with `GITLAWB_MAX_CONCURRENT_READS_PER_CALLER`. Pushes and the receive-pack advertisement have their own pools, so a read flood cannot shed an authenticated push. Default 128. REST blob responses are limited to 32 MiB each and a dedicated four-request pool holds admission through body delivery, bounding retained blob data to 128 MiB. |
| `GITLAWB_MAX_CONCURRENT_GIT_PUSHES` | Max concurrent `git-receive-pack` POST operations, in a pool separate from the read pool. The anon receive-pack `info/refs` advertisement runs in a third pool of the same size, disjoint from both, so an advertisement flood cannot shed a push either. Two per-source push caps are derived from this value (`/8`, floor 1) and have no env var of their own. Over-cap sheds a 503 + Retry-After. Default 32. |
| `GITLAWB_MAX_CONCURRENT_READS_PER_CALLER` | Max concurrent read ops a single caller may hold, so one caller cannot monopolize the read pool. Keyed on the resolved source IP, never the DID, and only as granular as `GITLAWB_TRUSTED_PROXY`: left unset, a node behind an edge or NAT keys every caller on the edge IP and this collapses to one global cap. Default 16. |
Expand Down
12 changes: 7 additions & 5 deletions crates/gitlawb-node/src/config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -234,11 +234,13 @@ pub struct Config {
/// bounds `RepoStore::{acquire,acquire_fresh,acquire_write}` — the Tigris
/// HEAD/GET on a read/advert acquire and the advisory-lock retry loop (incl. a
/// per-iteration `pg_try_advisory_lock` that can block on a hung Postgres pool)
/// on a write acquire. A concurrency permit is taken BEFORE this phase, and
/// `git_service_timeout_secs` only starts once git spawns, so without this the
/// acquire phase is unbounded: a stalled backend pins the permit and drains the
/// pool until every later request 503s. On expiry the permit is released and a
/// bounded 503 + Retry-After is returned (fail-closed). Kept separate from
/// on a write acquire. For REST blob reads, it also independently bounds the
/// preceding PostgreSQL authorization wait. A concurrency permit is taken
/// BEFORE this phase, and `git_service_timeout_secs` only starts once git
/// spawns, so without this the acquire phase is unbounded: a stalled backend
/// pins the permit and drains the pool until every later request 503s.
/// On expiry the permit is released and a bounded 503 + Retry-After is
/// returned (fail-closed). Kept separate from
/// `git_service_timeout_secs` because acquisition and git execution are distinct
/// cost centers — one shared budget would let a slow acquire starve git. Must be
/// positive; set it very large to effectively disable the bound. Default: 30s.
Expand Down