Skip to content
Closed
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
6633d17
fix(node): bound REST blob reads
Sep 7, 2026
95d295c
test(node): cover blob authorization denials.
Sep 7, 2026
d824cfa
fix(node): Hide Git diagnostics from blob error responses.
Sep 9, 2026
3d7032b
fix(node): close REST blob admission and error gaps
Sep 9, 2026
fc2d043
fix(node): acquire blob permits pre-DB and cover route/fallback arms
Sep 10, 2026
c63527c
fix(node): confirm blob absence against a readable store
Sep 12, 2026
8977ed4
fix(node): bound REST blob response delivery
Sep 12, 2026
e1fe66e
test(git): distinguish every bounded ref fallback
Sep 12, 2026
4344b77
docs(node): describe the cat-file blob read path
Sep 12, 2026
49aebb2
fix(node): prevent caching of authorized blob content
Sep 12, 2026
c566455
fix(node): pin non-blob denial and map unreadable store to 503
Sep 12, 2026
df5a283
style(repos): simplify blob semaphore permit assertion for clippy
Sep 13, 2026
f0d0025
fix(git): classify unreadable store with ProbeError and tighten blob …
Sep 13, 2026
eb1222d
test(node): assert full blob admission release after read errors
Sep 14, 2026
c15acf5
test(git): require probe completion before reprobe budget denial
Sep 14, 2026
77e9b76
test(node): make Windows regression fixtures portable
Sep 14, 2026
5d238ca
fix(sync): use a supported Windows promisor blob filter
Sep 14, 2026
2c7f60a
test(git): route write-then-exec fixtures through write_blob_probe_fi…
Sep 15, 2026
2bb398e
test(sync): assert configured partialclonefilter and pin platform con…
Sep 15, 2026
bbab52e
test(api,git): close write-fd window in exec'd fixtures
Sep 17, 2026
ad003b3
fix(api): clamp authorize_repo_read with acquire timeout in get_blob
Sep 18, 2026
a2c996a
docs(config): describe the blob authorization deadline
Sep 20, 2026
5f588c1
test(api): bound the blob authorization timeout regression
Sep 20, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(git): require probe completion before reprobe budget denial
Record completion after the probe writes its result, so a watchdog kill
cannot masquerade as the unaffordable-reprobe branch. Quote the log path
and leave scheduler margin while spending more than half the budget.

Refs #407
  • Loading branch information
euxaristia
euxaristia committed Sep 14, 2026
commit c15acf5089be1e527054535b52bd96ffb6fbe27c
23 changes: 12 additions & 11 deletions crates/gitlawb-node/src/git/store.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1439,29 +1439,32 @@ exit 1
let td = tempfile::TempDir::new().unwrap();
let bare = td.path().join("bare.git");
std::fs::create_dir_all(bare.join("objects/pack")).unwrap();
let log = td.path().join("spawns.log");
let log = td.path().join("probe spawns.log");
let quoted_log = format!("'{}'", log.display().to_string().replace('\'', "'\"'\"'"));
let fake = td.path().join("fakegit");
std::fs::write(
&fake,
format!(
"#!/bin/sh\n\
echo call >> {}\n\
echo call >> {quoted_log}\n\
if [ \"$1\" = \"cat-file\" ] && [ \"$2\" = \"--batch-check\" ]; then \
read spec; \
sleep 0.15; \
sleep 2.5; \
printf '%s\\n' \"$spec missing\"; \
echo done >> {quoted_log}; \
exit 0; \
fi\n\
exit 1\n",
log.display()
exit 1\n"
),
)
.unwrap();
let mut permissions = std::fs::metadata(&fake).unwrap().permissions();
permissions.set_mode(0o755);
std::fs::set_permissions(&fake, permissions).unwrap();

let budget = std::time::Duration::from_millis(200);
// Spend over half the budget while leaving 1.5s for scheduler jitter.
// The completion marker below must still rule out a watchdog kill.
let budget = std::time::Duration::from_secs(4);
let deadline = std::time::Instant::now() + budget;
let err = super::blob_metadata_bounded(
fake.to_str().unwrap(),
Expand All @@ -1476,12 +1479,10 @@ exit 1
.is_some(),
"exhausted reprobe budget must return GitServiceTimeout, got: {err:#}"
);
let spawns = std::fs::read_to_string(&log)
.map(|s| s.lines().count())
.unwrap_or(0);
assert_eq!(
spawns, 1,
"a confirming probe must not be spawned when remaining budget is insufficient"
std::fs::read_to_string(&log).unwrap(),
"call\ndone\n",
"the first probe must finish, without spawning an unaffordable confirming probe"
);
}

Expand Down