Skip to content
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(node): propagate federated peer truncation
  • Loading branch information
euxarist committed Sep 7, 2026
commit 48ec0c579b780a19f5c4198529365cf1cf49d5a7
91 changes: 87 additions & 4 deletions crates/gitlawb-node/src/api/repos.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3224,6 +3224,12 @@ struct FederatedPeerRepos {
node_url: String,
node_did: String,
repos: Vec<serde_json::Value>,
truncated: bool,
}

struct FederatedPeerPage {
repos: Vec<serde_json::Value>,
truncated: bool,
}

struct BoundedFederatedPeerRows(Vec<serde_json::Value>);
Expand Down Expand Up @@ -3313,7 +3319,7 @@ impl FederatedRepoBudget {
async fn fetch_federated_peer_repos(
client: &reqwest::Client,
url: &str,
) -> Option<Vec<serde_json::Value>> {
) -> Option<FederatedPeerPage> {
let mut response = client.get(url).send().await.ok()?;
if !response.status().is_success()
|| response
Expand All @@ -3322,6 +3328,11 @@ async fn fetch_federated_peer_repos(
{
return None;
}
let total = response
.headers()
.get("x-total-count")
.and_then(|value| value.to_str().ok())
.and_then(|value| value.trim().parse::<u64>().ok());

let capacity = response
.content_length()
Expand All @@ -3337,7 +3348,8 @@ async fn fetch_federated_peer_repos(
}

let BoundedFederatedPeerRows(repos) = serde_json::from_slice(&body).ok()?;
Some(repos)
let truncated = total.is_some_and(|total| total > repos.len() as u64);
Some(FederatedPeerPage { repos, truncated })
}

fn enrich_federated_repo(
Expand Down Expand Up @@ -3371,6 +3383,7 @@ where
continue;
};
nodes_queried += 1;
aggregate.truncated |= response.truncated;
for repo in response.repos {
let Some(repo) = enrich_federated_repo(repo, &response.node_url, &response.node_did)
else {
Expand Down Expand Up @@ -3459,10 +3472,11 @@ pub async fn list_federated_repos(
.await
.ok()
.flatten()
.map(|repos| FederatedPeerRepos {
.map(|page| FederatedPeerRepos {
node_url: peer_url,
node_did: peer_did,
repos,
repos: page.repos,
truncated: page.truncated,
})
}
})
Expand Down Expand Up @@ -4538,6 +4552,74 @@ mod tests {
byte_server.await.unwrap();
}

#[tokio::test]
async fn federated_peer_total_count_prevents_false_complete_page() {
let mut server = mockito::Server::new_async().await;
let body = serde_json::to_string(
&(0..MAX_FEDERATED_PEER_REPOS)
.map(|id| serde_json::json!({ "id": id }))
.collect::<Vec<_>>(),
)
.unwrap();
let page_mock = server
.mock("GET", "/api/v1/repos")
.with_status(200)
.with_header("content-type", "application/json")
.with_header("x-total-count", &(MAX_FEDERATED_PEER_REPOS + 1).to_string())
.with_body(body)
.expect(1)
.create_async()
.await;

let page = fetch_federated_peer_repos(
&reqwest::Client::new(),
&format!("{}/api/v1/repos", server.url()),
)
.await
.expect("the capped peer page is otherwise valid");
page_mock.assert_async().await;
assert_eq!(page.repos.len(), MAX_FEDERATED_PEER_REPOS);
assert!(page.truncated, "the peer total proves another row exists");

let mut aggregate = FederatedRepoBudget::new(300, 300, MAX_FEDERATED_REPO_JSON_BYTES);
let nodes = collect_federated_fetches(
[std::future::ready(Some(FederatedPeerRepos {
node_url: server.url(),
node_did: "did:key:peer".to_string(),
repos: page.repos,
truncated: page.truncated,
}))],
&mut aggregate,
)
.await;
assert_eq!(nodes, 1);
assert_eq!(aggregate.repos.len(), MAX_FEDERATED_PEER_REPOS);
assert!(
aggregate.truncated,
"the aggregate must not report the paged peer as complete"
);

let mut malformed_server = mockito::Server::new_async().await;
let malformed_mock = malformed_server
.mock("GET", "/api/v1/repos")
.with_status(200)
.with_header("content-type", "application/json")
.with_header("x-total-count", "not-a-count")
.with_body("[{}]")
.expect(1)
.create_async()
.await;
let malformed = fetch_federated_peer_repos(
&reqwest::Client::new(),
&format!("{}/api/v1/repos", malformed_server.url()),
)
.await
.expect("a malformed optional total must not discard a bounded page");
malformed_mock.assert_async().await;
assert!(!malformed.truncated);
assert_eq!(malformed.repos.len(), 1);
}

#[test]
fn federated_aggregate_stays_inside_row_and_serialized_byte_budgets() {
let mut rows = FederatedRepoBudget::new(3, 2, 4_096);
Expand Down Expand Up @@ -4600,6 +4682,7 @@ mod tests {
node_url: format!("https://peer-{i}.example"),
node_did: format!("did:key:peer-{i}"),
repos: vec![serde_json::json!({ "id": i })],
truncated: false,
})
});
}
Expand Down