Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: strengthen federated response bound tests per review
- db/mod.rs: add writer-ledger entries and disposition docs for the
  three federated route tests touching the peers table
- api/repos.rs: seed the envelope test repo under a non-node owner DID
  so node_did must equal the actual node DID; pin the outbound peer
  query to exact limit=200&offset=0; make the peer-table-overflow test
  use a reachable stub for every peer so the count bound is the only
  possible reason for truncated=true, and assert nodes_queried
  • Loading branch information
cairn-intern committed Sep 27, 2026
commit cf06b4f644b0218a721a80a9dedc0da978d3f738
45 changes: 38 additions & 7 deletions crates/gitlawb-node/src/api/repos.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4856,6 +4856,9 @@ mod tests {
/// (`count`, `nodes_queried`, `truncated`) and the per-repo annotations
/// (`node_url`, `node_did`, `local`) are asserted on an actual HTTP 200
/// body driven through `build_router`, not on a self-constructed value.
/// The seeded repo is deliberately owned by a DID other than the node:
/// the envelope must carry the node's DID, so a regression that reports
/// the owner DID instead would fail the `node_did` assertion.
#[sqlx::test]
async fn federated_route_envelope_annotates_repos_on_real_200_body(pool: sqlx::PgPool) {
use tower::ServiceExt;
Expand All @@ -4864,7 +4867,7 @@ mod tests {
let node_did = state.node_did.to_string();
state
.db
.create_repo(&repo_owned_by(&node_did))
.create_repo(&repo_owned_by("did:key:z6MkEnvelopeOwnerNotTheNode"))
.await
.expect("seed local repo");

Expand All @@ -4891,15 +4894,32 @@ mod tests {
}

/// `truncated` must be observable on the wire when the peer table holds
/// more rows than `MAX_FEDERATED_PEERS`. The peers point at an unreachable
/// address, so no live peer is needed; the count check fires before any
/// fetch is attempted.
/// more rows than `MAX_FEDERATED_PEERS`. Every seeded peer points at the
/// same reachable stub returning `[]`, so no fetch can fail and no peer
/// page can report truncation: the count bound is the only reason the
/// body says `truncated`. The `nodes_queried` assertion pins the fetch
/// side: every peer inside the bound is queried, and dropping the count
/// bound would report `truncated: false`.
#[sqlx::test]
async fn federated_route_reports_truncated_when_peer_table_overflows(pool: sqlx::PgPool) {
use tower::ServiceExt;

let mut peer_server = mockito::Server::new_async().await;
let peer_mock = peer_server
.mock("GET", "/api/v1/repos")
.match_query(mockito::Matcher::Exact(format!(
"limit={MAX_FEDERATED_PEER_REPOS}&offset=0"
)))
.with_status(200)
.with_header("content-type", "application/json")
.with_body("[]")
.expect(MAX_FEDERATED_PEERS)
.create_async()
.await;

let state = crate::test_support::test_state(pool.clone()).await;
sqlx::query("INSERT INTO peers (did, http_url, last_ping_ok, announced_at) SELECT 'peer-' || n, 'http://127.0.0.1:1/', TRUE, '2026-01-01T00:00:00Z' FROM generate_series(1, $1) n")
sqlx::query("INSERT INTO peers (did, http_url, last_ping_ok, announced_at) SELECT 'peer-' || n, $1, TRUE, '2026-01-01T00:00:00Z' FROM generate_series(1, $2) n")
.bind(peer_server.url())
.bind(MAX_FEDERATED_PEERS as i64 + 2)
.execute(&pool)
.await
Expand All @@ -4914,7 +4934,12 @@ mod tests {
Some(true),
"more peers than the bound must surface as truncated"
);
assert_eq!(body["nodes_queried"].as_u64(), Some(1));
assert_eq!(
body["nodes_queried"].as_u64(),
Some(1 + MAX_FEDERATED_PEERS as u64),
"the stub is reachable, so every peer inside the bound is queried"
);
peer_mock.assert_async().await;
}

/// A single unreachable peer must still flip `truncated` on the wire via
Expand Down Expand Up @@ -4952,7 +4977,13 @@ mod tests {
let mut peer_server = mockito::Server::new_async().await;
let peer_mock = peer_server
.mock("GET", "/api/v1/repos")
.match_query(mockito::Matcher::Any)
// Pin the outbound peer query parameters: production must request
// the bounded page. Dropping the parameters stops matching this
// mock, so the peer fetch fails and the body reports
// `truncated: true` instead of `false` below.
.match_query(mockito::Matcher::Exact(format!(
"limit={MAX_FEDERATED_PEER_REPOS}&offset=0"
)))
.with_status(200)
.with_header("content-type", "application/json")
.with_body(r#"[{"id": "peer-repo-1", "name": "from-peer"}]"#)
Expand Down
9 changes: 9 additions & 0 deletions crates/gitlawb-node/src/db/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9304,6 +9304,9 @@ mod peer_authority_tests {
/// | `manual_ping_uses_readiness_without_mutating_federation_gate` (api/peers.rs) | test-only fixture seed, same shape and same reason: the row under test must pre-exist so the assertion is about what the ping does NOT rewrite |
/// | `seed_peer` (p2p/mod.rs) | test-only fixture seed. Raw SQL so the gossip ingest tests can drive the known-peer gate directly, including the did:web case `upsert_peer` would refuse |
/// | `federated_peer_query_is_bounded` (api/repos.rs) | test-only fixture seed for the bounded federation query; inserts reachable rows without exercising peer admission |
/// | `federated_route_annotates_peer_repos_on_real_200_body` (api/repos.rs) | test-only fixture seed; inserts the mock peer row the bounded federation query reads, so the response-envelope assertions run against a real HTTP 200 body |
/// | `federated_route_reports_truncated_when_peer_fetch_fails` (api/repos.rs) | test-only fixture seed; seeds one unreachable peer so the fetch-failure path is the witness under test |
/// | `federated_route_reports_truncated_when_peer_table_overflows` (api/repos.rs) | test-only fixture seed; overflows the peer table past `MAX_FEDERATED_PEERS` so the count bound is the only witness for `truncated` |
///
/// And the `upsert_peer` CALL-SITE authority table, which the ledger above
/// structurally cannot hold, because the bootstrap site issues no SQL of its own
Expand Down Expand Up @@ -9390,6 +9393,12 @@ mod peers_table_writer_guard {
const LEDGER: &[(&str, usize)] = &[
("a_legacy_row_can_still_refresh_its_liveness", 1),
("federated_peer_query_is_bounded", 1),
("federated_route_annotates_peer_repos_on_real_200_body", 1),
("federated_route_reports_truncated_when_peer_fetch_fails", 1),
(
"federated_route_reports_truncated_when_peer_table_overflows",
1,
),
(
"gossip_ping_round_requires_two_failures_before_persisting_unreachable",
1,
Expand Down
Loading