Repository navigation
feat(storage): storage-agnostic BlobStore layer + push-latency quick wins #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kevincodex1
wants to merge
16
commits into
main
Choose a base branch
from
feat/storage-abstraction
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
b8a3bae
feat(storage): storage-agnostic BlobStore layer + push-latency quick …
kevincodex1 9016e25
fix(storage): address CodeRabbit review (data-integrity + robustness)
kevincodex1 7b93d40
fix(storage): address beardthelion review (lock soundness, durability…
kevincodex1 b357510
fix(storage): isolate advisory-lock pool + #[must_use] write guard
kevincodex1 242c593
fix(storage): propagate durability errors + serialize background uploads
kevincodex1 f17fee0
fix(storage): address final review round + multithreaded compression
kevincodex1 d30af0d
fix(storage): address CodeRabbit round — key backslash rejection, loc…
kevincodex1 8c4ec8e
fix(storage): pending-upload marker + review round fixes
kevincodex1 75060ea
fix(storage): versioned pending marker, claim-first creation, fs etag…
kevincodex1 f154768
docs(storage): ObjectMeta etag doc reflects the fs sidecar etag
kevincodex1 5605b9c
fix(storage): harden marker machinery — durable pre-ack, locked diver…
kevincodex1 3cbcb2b
fix(storage): keep the marker gauge live; stripe the fs publish lock
kevincodex1 7e9fde0
fix(storage): in-flight etag provenance closes the upload-to-clear cr…
kevincodex1 1d5b479
fix(storage): content-validated recovery, locked creation lifecycle, …
kevincodex1 b014ce7
merge: main into feat/storage-abstraction (port storage abstraction o…
kevincodex1 9ce694b
fix(storage): path-traversal barrier for sibling paths; restore the F…
kevincodex1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(storage): content-validated recovery, locked creation lifecycle, …
…dual lock keys jatmn round on 7e9fde0 (all seven findings): - Recovery validates heal candidates by CONTENT, not etag: it fetches the remote archive and compares its MD5 against the marker's recorded in-flight hash. This is backend-independent — correct under IPFS CIDs and SSE-KMS etags, and immune to the fs backend crashing between its sidecar and blob renames (stale bytes under a fresh etag now read as divergence, never as a completed upload). The fs backend's etag is the persisted content MD5, so a failed publish also restores the previous sidecar. - record_inflight_upload is fallible and aborts the PUT when the intent cannot be durably recorded — an upload must never outrun the marker that explains it. - Issue/close/merge handlers verify the pending marker actually exists before treating a failed release as recoverable; with no marker the request fails instead of acking an unprotected mutation. - Creation and fork publication run inside RepoStore::create_published, which holds the per-repo advisory lock for the whole claim-to- publication lifecycle: a push through the just-visible row serializes behind publication, so failure compensation can never destroy a concurrently accepted push. release_after_write is gone. - The ipfs backend is explicitly restricted to a single shared Kubo instance (MFS is daemon-local): startup warning + module/config/README docs state the deployment requirement. - Writers acquire BOTH the new SHA-256 advisory-lock key and the legacy DefaultHasher key (all-or-nothing per attempt, partial grabs released before retrying), so writer exclusion holds across a mixed-binary rolling deploy; the legacy key drops once the fleet is upgraded.
- Loading branch information
commit 1d5b479a101f99ab8c07b2efedd553deaa1accaf
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.