Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b8a3bae
feat(storage): storage-agnostic BlobStore layer + push-latency quick …
kevincodex1 Jun 22, 2026
9016e25
fix(storage): address CodeRabbit review (data-integrity + robustness)
kevincodex1 Jun 23, 2026
7b93d40
fix(storage): address beardthelion review (lock soundness, durability…
kevincodex1 Jun 23, 2026
b357510
fix(storage): isolate advisory-lock pool + #[must_use] write guard
kevincodex1 Jun 24, 2026
242c593
fix(storage): propagate durability errors + serialize background uploads
kevincodex1 Jun 24, 2026
f17fee0
fix(storage): address final review round + multithreaded compression
kevincodex1 Jul 23, 2026
d30af0d
fix(storage): address CodeRabbit round — key backslash rejection, loc…
kevincodex1 Jul 23, 2026
8c4ec8e
fix(storage): pending-upload marker + review round fixes
kevincodex1 Jul 23, 2026
75060ea
fix(storage): versioned pending marker, claim-first creation, fs etag…
kevincodex1 Jul 23, 2026
f154768
docs(storage): ObjectMeta etag doc reflects the fs sidecar etag
kevincodex1 Jul 23, 2026
5605b9c
fix(storage): harden marker machinery — durable pre-ack, locked diver…
kevincodex1 Jul 24, 2026
3cbcb2b
fix(storage): keep the marker gauge live; stripe the fs publish lock
kevincodex1 Jul 24, 2026
7e9fde0
fix(storage): in-flight etag provenance closes the upload-to-clear cr…
kevincodex1 Jul 25, 2026
1d5b479
fix(storage): content-validated recovery, locked creation lifecycle, …
kevincodex1 Jul 26, 2026
b014ce7
merge: main into feat/storage-abstraction (port storage abstraction o…
kevincodex1 Aug 31, 2026
9ce694b
fix(storage): path-traversal barrier for sibling paths; restore the F…
kevincodex1 Aug 31, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(storage): path-traversal barrier for sibling paths; restore the F…
…4 unlock shape

Two CI failures from the storage-abstraction merge, both in this layer.

CodeQL (rust/path-injection). Every path derived from a repo path — the
pending-upload marker, its rename-temp, and the swap phase's .bak- and
.tmp-extract. work dirs — is rebuilt with join/with_file_name, and a rebuilt
path is a new question no earlier validation answers. Add
validated_sibling_path (single-segment name, containment under the repo
parent, explicit Component::Normal walk) and validated_repo_path_in (the same
walk for a repo path arriving as a parameter, applied where the filesystem
work happens rather than trusted across a call boundary), then route every
marker/backup/temp construction and the sweep's entry-derived repo paths
through them before any fs call. pending_upload_marker is fallible as a
result; the cleanup paths that cannot propagate treat a rejected path as
"no marker", the same conservative answer they already give for an absent one.

INV-22 F4 gate. The merge moved the advisory unlock from
RepoWriteGuard::release into LockedConn::unlock and, in doing so, took the
connection out of self BEFORE awaiting pg_advisory_unlock — the exact shape
#174 F4 forbids, since a cancellation mid-await then leaves Drop with
conn == None and strands the session lock. Restore the reviewed shape: unlock
through the still-owned connection, dispose of it only when the unlock errors
(#174 F3b), and set the new released flag only once the await resolves so the
Drop backstop stays live until then. tests/inv22_gates.rs follows the code to
its new home rather than being deleted with it; the invariant is unchanged.
  • Loading branch information
kevincodex1 committed Aug 31, 2026
commit 9ce694b097718040da18b865dfec23a27b9a9465
Loading
Loading