-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Save/Load Atlas Functionality #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
980ac9b
Boost serialization code + PreSave/PostLoad functions
0ce0d6d
Serialization code + added constructor for KFDB loading
3e58a1f
Serialization code + added include for tuple serialization
ae0ed23
Load/Save Atlas functions declaration
b3a7adc
PreSave/PostLoad code added
c4ce511
Functions for Save/Load + constructor + avoid infinite loop in Detect…
9e603a7
avoid failure in 1st LBA post merge
3ae3981
added condition in color index
2dd5fef
PreSave/PostLoad functions + avoid getting empty camera center
a9948ee
Added include and examples
ea2da47
Save/Load Functions
a77e821
Set StepbyStep
dcbb819
Added include and example code
114227e
Add Mono scripts in CMakeLists.txt
c9316ed
Unserialize MspMaps
ce8a338
Mono Scripts
d2f6ddd
Add Mono code lines
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Added include and examples
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not directly use boost library? It works with me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I serialized large maps, I had a bug when recovering the MapPoints's observations from the backup. Serializing mObservations directly solved the problem. However those observations contain a tuples. If I'm not mistaken, by default, there is no tuple serialization in Boost. That's why this is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't meet this kind of problem. Will your program break down with red error? Recover from backup is ok from my side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if this is helpful. https://github.com/UZ-SLAMLab/ORB_SLAM3/pull/310/files#r627844802
But I think add serialize_tuple.h is also a good option:)