Skip to content

Save/Load Atlas Functionality #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
neo-knight-td wants to merge 17 commits into from
Closed

Save/Load Atlas Functionality #310

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
980ac9b
Boost serialization code + PreSave/PostLoad functions
May 4, 2021
0ce0d6d
Serialization code + added constructor for KFDB loading
May 4, 2021
3e58a1f
Serialization code + added include for tuple serialization
May 4, 2021
ae0ed23
Load/Save Atlas functions declaration
May 4, 2021
b3a7adc
PreSave/PostLoad code added
May 4, 2021
c4ce511
Functions for Save/Load + constructor + avoid infinite loop in Detect…
May 4, 2021
9e603a7
avoid failure in 1st LBA post merge
May 4, 2021
3ae3981
added condition in color index
May 4, 2021
2dd5fef
PreSave/PostLoad functions + avoid getting empty camera center
May 4, 2021
a9948ee
Added include and examples
May 4, 2021
ea2da47
Save/Load Functions
May 4, 2021
a77e821
Set StepbyStep
May 4, 2021
dcbb819
Added include and example code
May 4, 2021
114227e
Add Mono scripts in CMakeLists.txt
Sep 18, 2021
c9316ed
Unserialize MspMaps
Sep 18, 2021
ce8a338
Mono Scripts
Sep 18, 2021
d2f6ddd
Add Mono code lines
Sep 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Unserialize MspMaps
  • Loading branch information
Thomas Dutrannois committed Sep 18, 2021
commit c9316ed527356e682fab67d70b813342f6ae3c5c
2 changes: 1 addition & 1 deletion include/Atlas.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class Atlas
//ar.template register_type<KannalaBrandt8>();

//Save/Load all objects
ar & mspMaps;
//ar & mspMaps;
ar & mvpBackupMaps;
Copy link

@fliegend fliegend May 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this necessary?

Copy link
Author

@neo-knight-td neo-knight-td May 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that you mention it, serializing mspMaps should not be required given that these are backed up in PreSave and rebuilt in PostLoad. I have not yet tested without that line if it works. If it's the case I'll make the change ;) Thanks !

Copy link

@fliegend fliegend May 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, either mspMaps or mvpBackupMaps is ok. https://github.com/UZ-SLAMLab/ORB_SLAM3/pull/310/files#r627846281

//ar & mvpCameras;
ar & mvpBackupCamPin;
Expand Down