fix(grid-visibility-manager): consider only checked columns when computing isDirty$
#444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatalinB7
requested review from
a team,
AlexAndriesUiPath and
caleniuc
and removed request for
a team
AlexAndriesUiPath
previously approved these changes
Dec 20, 2023
anbalase
reviewed
Dec 20, 2023
anbalase
previously approved these changes
Dec 20, 2023
CatalinB7
dismissed stale reviews from anbalase and AlexAndriesUiPath
via
078989c
consider only checked columns
CatalinB7
force-pushed
the
fix/columns_visibility
branch
from
078989c to
5fb0dcf
Compare
CatalinB7
force-pushed
the
fix/columns_visibility
branch
from
5fb0dcf to
f67d016
Compare
AlexAndriesUiPath
approved these changes
Dec 20, 2023
|
Code Climate has analyzed commit f67d016 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 90.4% (0.0% change). View more on Code Climate. |
gheorghitahurmuz
pushed a commit
that referenced
this pull request
Feb 5, 2024
fix(grid-visibility-manager): consider only checked columns when computing `isDirty$`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.