Skip to content

fix(grid-visibility-manager): consider only checked columns when computing isDirty$ #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CatalinB7 merged 2 commits into from
Dec 20, 2023
Merged

fix(grid-visibility-manager): consider only checked columns when computing isDirty$ #444

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71f6bf1
fix(grid): change visibility-manager isDirty$
CatalinB7 Dec 20, 2023
f67d016
chore: bump version to v15.0.19
CatalinB7 Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(grid): change visibility-manager isDirty$ 
consider only checked columns
  • Loading branch information
@CatalinB7
CatalinB7 committed Dec 20, 2023
commit 71f6bf18b1f1dcd3e5cb52dd2ee2c57e58c820fe
2 changes: 1 addition & 1 deletion projects/angular/components/ui-grid/src/managers/visibility-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export class VisibilityManger<T extends IGridDataEntry> {
isDirty$ = this.options$.pipe(
filter(() => !!this._initial),
map(o => ([o.map(this._mapToVisibleDiff), this._initial])),
map(([current, initial]) => !isEqual(current, initial)),
map(([current, initial]) => !isEqual(current?.filter(v => v.checked), initial?.filter(v => v.checked))),
);

set columns(columns: UiGridColumnDirective<T>[]) {
Expand Down