Use AbstractModuleSource [[ModuleSource]] slot #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
approved these changes
Feb 5, 2025
guybedford
pushed a commit
that referenced
this pull request
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the spec to match the latest source phase imports proposal, which changed to using a
[[ModuleSource]]slot fully defined in ECMA-262 in tc39/proposal-source-phase-imports#69 (and the corresponding upstream PR).As a result we can set the WebAssembly.Module directly into this slot without needing any custom slots or to provide the
GetModuleSourceconcrete method.We may also be able to upgrade
HostGetModuleSourceNameto rather be the newHostGetModuleSourceModuleRecord, which is separately tracking in tc39/proposal-source-phase-imports#70.