Upstream HostGetModuleSourceModuleRecord host change from ESM Phase Imports #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
approved these changes
Feb 7, 2025
guybedford
pushed a commit
to guybedford/ecma262
that referenced
this pull request
Feb 11, 2025
Collaborator
Author
|
This was updated for the ESM Integration in WebAssembly/esm-integration#98. |
guybedford
pushed a commit
to guybedford/ecma262
that referenced
this pull request
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the ESM Phase Imports proposal, we ended up refactoring the
HostGetModuleSourceNamehost call (which takes a module source object, and returns its type name) to instead be aHostGetModuleSourceModuleRecordto get a module record from a module source object, and then separately call a newGetModuleSourceKind()abstract method on this module record.Leaving this hostcall refactoring for progression of the ESM Phase Imports can be avoided by fully upstreaming this change already now in the source phase imports proposal as a refactoring non-normative editorial change, down to the hostcall structure changing of course.
This mirrors the
[[ModuleSource]]internal slot case and closes the loop on bi-directional referencing between module source objects and their underlying module records.