Implement toolbar dividers #1031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
NICE! I took the liberty of pushing a teensy bit of polish to the divider itself. Code also looks good to me — @youknowriad any concerns? Otherwise 👍 |
aduth
reviewed
Jun 6, 2017
| title: wp.i18n.__( 'Convert to ordered' ), | ||
| }, | ||
| { | ||
| showDivider: true, |
Member
There was a problem hiding this comment.
At a glance, it's not entirely obvious to me where the divider would be shown. To the left or right?
Author
There was a problem hiding this comment.
Good point. It shows to the left so I suppose the simple solution is to rename it to leftDivider.
Author
|
I think I've addressed all concerns so I'll merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds toolbar dividers:
They were added to match the mockup here: #972 (comment)