Support nested array of toolbar controls #1173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
General Interface
aduth
changed the title
BoardJames
approved these changes
Jun 15, 2017
BoardJames
left a comment
BoardJames
left a comment
There was a problem hiding this comment.
It looks great. It is a much nicer solution and I can't find any errors.
aduth
force-pushed
the
update/nested-toolbar-controls
branch
from
cd1462f to
bf96ef4
Compare
Member
Author
|
Rebased and included updated text for BlockControls documentation added in #1172. Will merge shortly. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1031
This pull request seeks to explore an alternative to assigning a
leftDividerproperty on a control for displaying dividers, instead representing division between sets of controls by a nested array structure. With these changes, the<Toolbar />component now acceptscontrolsas either an array of objects, or now also as an array of array of objects, where in the latter case each top-level array is considered a "set of controls" with dividers between sets.Testing instructions:
Verify that unit tests pass:
Ensure that there are no regressions in the behavior of toolbar controls, both for non-nested controls (e.g. image) and also for nested controls (e.g. freeform block).