renamed _wpGutenbergCodeEditorSettings to _wpCodeEditorSettings #11189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Unless I'm mistaken, this is dead code which should be removed entirely, since the code editor was deprecated and later removed as of #10396. cc @youknowriad |
Member
|
Yes, this is dead code. We ought to remove it from Core as well. |
Member
|
I've created #11342 which removes this variable from the plugin, and https://core.trac.wordpress.org/ticket/45248 which removes it from core. |
Contributor
|
Thanks for your time @chetansatasiya this is indeed dead code now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
renamed _wpGutenbergCodeEditorSettings to _wpCodeEditorSettings
Fix: #10847