Skip to content

Conversation

@noisysocks
Copy link
Member

@noisysocks noisysocks commented Nov 1, 2018

Closes #10847.

Removes _wpGutenbergCodeEditorSettings. This is dead code since the HTML block no longer uses wp.codeEditor as of #10396.

Remove _wpGutenbergCodeEditorSettings and the assets required to use
wp.codeEditor. Gutenberg no longer uses this as of cc5bf5c.
@noisysocks noisysocks requested a review from pento November 1, 2018 00:58
@noisysocks noisysocks added [Type] Code Quality Issues or PRs that relate to code quality [Type] Performance Related to performance efforts labels Nov 1, 2018
@noisysocks noisysocks added this to the 4.3 milestone Nov 1, 2018
@noisysocks noisysocks removed the [Type] Performance Related to performance efforts label Nov 1, 2018
@noisysocks noisysocks changed the title Remove _wpGutenbergCodeEditorSettings and wp.codeEditor assets Remove _wpGutenbergCodeEditorSettings Nov 1, 2018
Copy link
Member

@pento pento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Red code is best code.

@aduth aduth merged commit 1acf062 into master Nov 1, 2018
@aduth aduth deleted the fix/remove-code-editor-assets branch November 1, 2018 12:59
daniloercoli added a commit that referenced this pull request Nov 1, 2018
…rnmobile/port-quote-block-step-1

* 'master' of https://github.com/WordPress/gutenberg: (22 commits)
  Add removed periods to block descriptions. (#11367)
  Remove findDOMNode usage from the inserter (#11363)
  Remove deprecated componentWillReceiveProps from TinyMCE component (#11368)
  Create file blocks when dropping multiple files at once (#11297)
  Try avoiding the deprecated findDOMNode API from DropZone Provider (#11168)
  Fix: make meta+A behaviour of selecting all blocks work on safari and firefox. (#8180)
  Remove _wpGutenbergCodeEditorSettings and wp.codeEditor assets (#11342)
  Remove the Cloudflare warning (#11350)
  Image Block: Use source_url for media file link (#11254)
  Enhance styling of nextpage block using the Hr element (#11354)
  Embed block refactor and tidy (#10958)
  Nonce Middleware: Wrap the nonce middleware function into it's own function that isn't regenerated on every API request. (#11347)
  Fix RTL block alignments (#11293)
  RichText: fix buggy enter/delete behaviour (#11287)
  Remove code coverage setup (#11198)
  Parser: Runs all parser implementations against the same tests (#11320)
  Stop trying to autosave when title and classic block content both are empty. (#10404)
  Fix "Mac OS" typo + use fancy quotes consistently (#11310)
  Update documentation link paths (#11324)
  Editor: Reshape blocks state under own key (#11315)
  ...

# Conflicts:
#	gutenberg-mobile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants