Editor: Reshape blocks state under own key #11315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
Framework
aduth
force-pushed
the
update/editor-blocks-state
branch
from
62ef5e3 to
effdcb0
Compare
jorgefilipecosta
approved these changes
Oct 31, 2018
Member
jorgefilipecosta
left a comment
jorgefilipecosta
left a comment
There was a problem hiding this comment.
I did some smoke testing and I did not managed to catch any regression. The tests are passing. And I did some "grepping" and I did not managed to catch any change that was missing. So it LGTM 👍
It would be good if we merge as early as possible in a release so we maximize the time of this change on master (witgout being released) to increase the porbability of catching any bug.
aduth
force-pushed
the
update/editor-blocks-state
branch
from
effdcb0 to
fc7db52
Compare
Member
Author
|
I probably should've mentioned as well that it's a significantly easier review using the GitHub "Hide whitespace changes" setting:
|
aduth
force-pushed
the
update/editor-blocks-state
branch
from
fc7db52 to
28a7f07
Compare
Member
Yes, that's the option I used, it makes the changes much easier to understand. |
daniloercoli
added a commit
that referenced
this pull request
Nov 1, 2018
…rnmobile/port-quote-block-step-1 * 'master' of https://github.com/WordPress/gutenberg: (22 commits) Add removed periods to block descriptions. (#11367) Remove findDOMNode usage from the inserter (#11363) Remove deprecated componentWillReceiveProps from TinyMCE component (#11368) Create file blocks when dropping multiple files at once (#11297) Try avoiding the deprecated findDOMNode API from DropZone Provider (#11168) Fix: make meta+A behaviour of selecting all blocks work on safari and firefox. (#8180) Remove _wpGutenbergCodeEditorSettings and wp.codeEditor assets (#11342) Remove the Cloudflare warning (#11350) Image Block: Use source_url for media file link (#11254) Enhance styling of nextpage block using the Hr element (#11354) Embed block refactor and tidy (#10958) Nonce Middleware: Wrap the nonce middleware function into it's own function that isn't regenerated on every API request. (#11347) Fix RTL block alignments (#11293) RichText: fix buggy enter/delete behaviour (#11287) Remove code coverage setup (#11198) Parser: Runs all parser implementations against the same tests (#11320) Stop trying to autosave when title and classic block content both are empty. (#10404) Fix "Mac OS" typo + use fancy quotes consistently (#11310) Update documentation link paths (#11324) Editor: Reshape blocks state under own key (#11315) ... # Conflicts: # gutenberg-mobile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #10844
This pull request seeks to refactor blocks state to track blocks state as a single subtree within the
editorreducer.Before:
editoreditsblocksByClientIdblockOrderAfter:
editoreditsblocksbyClientIdorderThe rationale for this change is in better representing treatment the two as a collective unit, facilitating work in #10844 to shift the
isDirtytracking fromeditortoblocks, and enabling the simplification of e.g. memoized selector cache-busting, which can reference the singleeditor.blocks(where previously it would enumerate bothblocksByClientIdandblockOrder).Testing instructions:
This is a refactoring change. There should be no notable impact on behavior.