Remove duplicate toolbarcontainer class name #12357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`components-toolbar` is added by `ToolbarContainer` itself, so we don’t need to add it again
|
|
||
| return ( | ||
| <ToolbarContainer className={ classnames( 'components-toolbar', className ) }> | ||
| <ToolbarContainer className={ className }> |
Member
There was a problem hiding this comment.
Hi @johngodley, in this file, we are in the components/toolbar component so I think it makes sense to add the class here like we do for the DropdownMenu component, as an alternative I think we should remove the class addition from the ToolbarContainer component.
youknowriad
pushed a commit
that referenced
this pull request
Jan 9, 2019
* Remove duplicate toolbarcontainer class name `components-toolbar` is added by `ToolbarContainer` itself, so we don’t need to add it again * Swap components-toolbar between container and toolbar
youknowriad
pushed a commit
that referenced
this pull request
Jan 9, 2019
* Remove duplicate toolbarcontainer class name `components-toolbar` is added by `ToolbarContainer` itself, so we don’t need to add it again * Swap components-toolbar between container and toolbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class
components-toolbarappears twice in the DOM, added by<Toolbar />and<ToolbarContainer />.This PR removes the class from
<Toolbar />so it's not passed down to<ToolbarContainer />and so won't appear twice.How has this been tested?
components-toolbaron the block toolbarTypes of changes
Minor class removal