Skip to content

Remove duplicate toolbarcontainer class name #12357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowriad merged 2 commits into from
Dec 20, 2018
Merged

Remove duplicate toolbarcontainer class name #12357

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d12416
Remove duplicate toolbarcontainer class name
johngodley Nov 27, 2018
11eb7fe
Swap components-toolbar between container and toolbar
johngodley Dec 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/components/src/toolbar/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ function Toolbar( { controls = [], children, className, isCollapsed, icon, label
}

return (
<ToolbarContainer className={ classnames( 'components-toolbar', className ) }>
<ToolbarContainer className={ className }>
Copy link
Member

@jorgefilipecosta jorgefilipecosta Nov 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @johngodley, in this file, we are in the components/toolbar component so I think it makes sense to add the class here like we do for the DropdownMenu component, as an alternative I think we should remove the class addition from the ToolbarContainer component.

{ flatMap( controlSets, ( controlSet, indexOfSet ) => (
controlSet.map( ( control, indexOfControl ) => (
<ToolbarButton
Expand Down