Skip to content

Conversation

@mkaz
Copy link
Member

@mkaz mkaz commented Dec 15, 2018

Description

When visiting the Gutenberg Handbook the Contributors index page is
blank. See: https://wordpress.org/gutenberg/handbook/contributors/

This PR adds some basic content and links to find more, including
linking back to the repo's contributing document.

Preview: https://github.com/WordPress/gutenberg/blob/docs/contrib-readme/docs/contributors/readme.md

Types of changes

Documentation.

When visiting the Gutenberg Handbook the Contributors index page is
blank. See: https://wordpress.org/gutenberg/handbook/contributors/

This PR adds some basic content and links to find more, including
linking back to the repo's contributing document.
@mkaz mkaz added the [Type] Developer Documentation Documentation for developers label Dec 15, 2018
@mkaz mkaz self-assigned this Dec 15, 2018
@gziolo gziolo added this to the Documentation & Handbook milestone Dec 16, 2018
Copy link
Contributor

@chrisvanpatten chrisvanpatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes; thanks for tackling this!

Copy link
Contributor

@chrisvanpatten chrisvanpatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @mkaz, here's a gold medal for you! 🥇

@chrisvanpatten chrisvanpatten merged commit 6390264 into master Dec 17, 2018
@aduth aduth deleted the docs/contrib-readme branch December 18, 2018 15:14
@aduth
Copy link
Member

aduth commented Dec 18, 2018

While tests have been unreliable for a few days, note that there was a legitimate failure here with regards to updates to the generated documentation. This is now reflected in the unrelated #12983.

@chrisvanpatten
Copy link
Contributor

@aduth Sorry I missed this earlier. This is 100% my fault. I should have been more meticulous in my review here.

Aside from my obvious mistake in missing the error in Travis, I am wondering why Husky didn't pick this up and prevent committing. I believe Husky runs checks to see if there are any manifest changes. Further I'll look into a way to make docs-related errors easier to see inside Travis.

youknowriad pushed a commit that referenced this pull request Jan 9, 2019
* Add content to Contributors index page

When visiting the Gutenberg Handbook the Contributors index page is
blank. See: https://wordpress.org/gutenberg/handbook/contributors/

This PR adds some basic content and links to find more, including
linking back to the repo's contributing document.

* Remove newlines, update links
youknowriad pushed a commit that referenced this pull request Jan 9, 2019
* Add content to Contributors index page

When visiting the Gutenberg Handbook the Contributors index page is
blank. See: https://wordpress.org/gutenberg/handbook/contributors/

This PR adds some basic content and links to find more, including
linking back to the repo's contributing document.

* Remove newlines, update links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants