Build tooling: Fix Travis failures with Docker instances #12983
Conversation
gziolo
added
[Type] Bug
gziolo
requested review from
a team,
aduth,
jorgefilipecosta and
youknowriad
bin/install-wordpress.sh
Outdated
| docker-compose $DOCKER_COMPOSE_FILE_OPTIONS run --rm -u 33 $CLI plugin activate gutenberg --quiet | ||
|
|
||
| # Install a dummy favicon to avoid 404 errors. | ||
| echo -e $(status_message "Intalling a dummy favicon...") |
|
https://wordpress.slack.com/archives/C02QB2JS7/p1545145317102800:
|
tofumatt
left a comment
tofumatt
left a comment
There was a problem hiding this comment.
Looks good to me; 🚢 if Travis is green.
I think we need those user ID flags for any command really, I wonder if we should just have a helper that outputs them and our $DOCKER_COMPOSE_FILE_OPTIONS and all that. A thought for a future refactor 😉
| }, | ||
| { | ||
| "title": "Contributors", | ||
| "title": "Contributors Guide", |
There was a problem hiding this comment.
Should not be here, right?
| "title": "Contributors Guide", | |
| "title": "Contributors", |
There was a problem hiding this comment.
I thought it should be as part of npm run build:docs 🤔
There was a problem hiding this comment.
See #12910 (comment)
The unreliability of the build has forced people into merging in a failing state. In this case, it was a legitimate failure which was merged.
It must be fixed, so may as well be here, or to master directly.
There was a problem hiding this comment.
There was no other way to make build pass, if you would open PR with only docs changes introduced it would fail on tests 🤷♂️
There was a problem hiding this comment.
What was the problem here? Did the manifest change at some point but not get committed?
There was a problem hiding this comment.
(And sorry I'm just seeing this)
There was a problem hiding this comment.
I think I changed the title on the contributors page but did not generate the manifest and commit. We missed it because Travis was throwing false errors, we just assumed it was wrong.
I think ideally we let whatever system that needs the generated file to generate at time of need and not have to try to remember generating and committing.
There was a problem hiding this comment.
@mkaz do you commit from the command line? I think Husky should have run the check automatically too. If it didn’t that could be another thing to look into.
There was a problem hiding this comment.
yep, commit from the command line and didn't see errors there
* Build tooling: Fix Travis failures with Docker instances * Docs: Fix manifest file * chore: Fix typo
* Build tooling: Fix Travis failures with Docker instances * Docs: Fix manifest file * chore: Fix typo
This PR adds some more debugging details to the shell scripts which installs WordPress instance using Docker.
It also fixes permissions for the files managed on Travis.