Skip to content

Conversation

@Tug
Copy link
Contributor

@Tug Tug commented Dec 19, 2018

Description

This PR exports unregisterBlockType from the @wordpress/blocks package for the mobile build.

How has this been tested?

Tested as part of wordpress-mobile/gutenberg-mobile#406

Types of changes

  • Mobile compatibility changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@Tug Tug self-assigned this Dec 19, 2018
@Tug Tug requested review from hypest, koke and pinarol December 19, 2018 14:38
Copy link
Contributor

@koke koke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had hoped we could use wp.hooks for this, but this works too 👍

@hypest
Copy link
Contributor

hypest commented Dec 19, 2018

This only affects .native files and is approved so, will merge it now.

@hypest hypest merged commit 262deea into master Dec 19, 2018
@hypest hypest deleted the rnmobile/blocks-expose-unregisterBlockType branch December 19, 2018 16:10
@gziolo gziolo added this to the Mobile Alpha milestone Dec 20, 2018
@gziolo gziolo added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants