Disable Code and More blocks for release #406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
koke
reviewed
Dec 19, 2018
| setUnregisteredTypeHandlerName( UnsupportedBlock.name ); | ||
|
|
||
| // disable Code and More blocks for release | ||
| if ( ! __DEV__ ) { |
Contributor
Author
There was a problem hiding this comment.
I'm surprised by the fact that the react-native documentation only has a very succinct mention of this global variable.
Still though, it's provided by react-native to differentiate a development build from a release one.
I've updated the testing instructions :)
koke
approved these changes
Dec 19, 2018
Member
koke
left a comment
koke
left a comment
There was a problem hiding this comment.
It took me a while to figure out how to test this in the app, but it works 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #398
This PR unregisters
CodeandMorefor the prod build.Testing Instructions
yarn startandyarn androidoryarn iosand notice the Code and More blocks are visiblenode_modules/.bin/react-native run-ios --configuration Releaseand notice the Code and More blocks appear as unsupported blocks.