Media upload change thumb on progress #13764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
the
Mobile App - i.e. Android or iOS
Contributor
Author
|
@etoledom can you please review this? |
etoledom
approved these changes
Feb 18, 2019
Contributor
etoledom
left a comment
etoledom
left a comment
There was a problem hiding this comment.
Working good 🎉
Tested via wordpress-mobile/WordPress-iOS#10981
Thank you @SergioEstevao for also fixing the BottomSheet warnings!
SergioEstevao
deleted the
rnmobile/media_upload_change_thumb_on_progress
branch
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Allow progress call to update the thumbnail image. * If we already have a subscription don’t go it again. * Fix bottomsheet event removal.
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* Allow progress call to update the thumbnail image. * If we already have a subscription don’t go it again. * Fix bottomsheet event removal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the possibility to send an updated thumbnail while sending progress updates.
Fix the bottom sheet unmount.