Support for updating thumbnails while image upload is ongoing. #576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # gutenberg
# Conflicts: # bundle/android/App.js # bundle/android/App.js.map # bundle/ios/App.js # bundle/ios/App.js.map
Contributor
Author
|
@etoledom can you please have a look on this? |
# Conflicts: # gutenberg
etoledom
approved these changes
Feb 18, 2019
Contributor
etoledom
left a comment
etoledom
left a comment
There was a problem hiding this comment.
Working good 🎉
Tested via wordpress-mobile/WordPress-iOS#10981
One detail:
Maybe we should merge from develop and regenerate the bundles?
Not sure if this these bundles conflict with changes from the last release. 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just updates the reference of Gutenberg to support this feature.
Related GB PR: WordPress/gutenberg#13764