Skip to content

Conversation

@nylen
Copy link
Member

@nylen nylen commented Aug 10, 2017

Per https://docs.codecov.io/v4.3.6/docs/comparing-commits#section-resolution, if Codecov does not find a coverage report for the "base commit" of a pull request (the commit the PR shares in common with master), then it will attempt to find a similar commit and use it as the base.

This causes incorrect coverage results, I suspect it is the reason the report in #2226 is wrong and partly related to the Codecov issues in #2296 as well.

Testing at #2296 seems to indicate that adding this setting has the intended effect, and https://docs.codecov.io/v4.3.6/docs/commit-status seems to indicate that this situation won't cause a build failure due to the default setting of if_not_found: success.

@aduth
Copy link
Member

aduth commented Aug 14, 2017

From the code snippet provided in their docs, it seems false is the default value anyways?

check if you allow offsets (default False)

https://docs.codecov.io/v4.3.6/docs/comparing-commits#section-resolution

Would this have any negative impact on rebases since the base commit would change?

@nylen
Copy link
Member Author

nylen commented Aug 15, 2017

Good catch on the default being False, so this shouldn't do anything.

I re-ran my test from #2296 with try/improved-arrow-nav-original-without-codecov-change and try/improved-arrow-nav-original-codecov-try2. This time I saw the same, invalid result on both branches.

@nylen nylen closed this Aug 15, 2017
@nylen nylen deleted the update/codecov-no-approx-compare branch August 15, 2017 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants