Skip to content

Conversation

@youknowriad
Copy link
Contributor

This fixes the first part of #2324

Also fixes some React Warnings when the color was unset.

@youknowriad youknowriad added the [Type] Bug An existing feature does not function as intended label Aug 11, 2017
@youknowriad youknowriad self-assigned this Aug 11, 2017
@youknowriad youknowriad requested a review from mtias August 11, 2017 12:32
@codecov
Copy link

codecov bot commented Aug 11, 2017

Codecov Report

Merging #2361 into master will decrease coverage by 0.74%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2361      +/-   ##
==========================================
- Coverage   25.06%   24.32%   -0.75%     
==========================================
  Files         153      155       +2     
  Lines        4760     4905     +145     
  Branches      801      829      +28     
==========================================
  Hits         1193     1193              
- Misses       3014     3131     +117     
- Partials      553      581      +28
Impacted Files Coverage Δ
blocks/library/cover-text/index.js 35% <ø> (ø) ⬆️
blocks/library/button/index.js 26.66% <ø> (ø) ⬆️
editor/sidebar/post-taxonomies/index.js 0% <0%> (ø) ⬆️
...itor/sidebar/post-taxonomies/flat-term-selector.js 0% <0%> (ø)
...ebar/post-taxonomies/hierarchical-term-selector.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a08dae6...00bc22c. Read the comment docs.

@aduth
Copy link
Member

aduth commented Aug 11, 2017

When creating a Cover Text block, adding text, selecting colors, and refreshing, the block shows as externally modified.

@youknowriad
Copy link
Contributor Author

weird @codecov this doesn't affect the coverage in theory (probably related to #2354)

@aduth
Copy link
Member

aduth commented Aug 11, 2017

Oh, I see the issue, though dunno if we want to address here. This is causing the cover block to be saved with <p class="false"> in some cases?

const className = dropCap && 'has-drop-cap';

@youknowriad
Copy link
Contributor Author

@aduth Yeah, unrelated to this PR, I can fix it separately

@youknowriad youknowriad merged commit 898a793 into master Aug 11, 2017
@youknowriad youknowriad deleted the fix/active-color branch August 11, 2017 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants