Try: fix gray gap. #27187
Closed
Try: fix gray gap. #27187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
the
[Type] Regression
|
Size Change: -10 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
karmatosed
approved these changes
Nov 23, 2020
Member
karmatosed
left a comment
karmatosed
left a comment
There was a problem hiding this comment.
In testing this got rid of the grey gap at the bottom, thanks @jasmussen.
Contributor
Author
|
Thank you, I'll let this one sit to see if the checks pass! |
ellatrix
approved these changes
Nov 24, 2020
Member
ellatrix
left a comment
ellatrix
left a comment
There was a problem hiding this comment.
Let's merge this if it does the trick. e2e test failures seem to be intermittent.
Fixes #27157.
jasmussen
force-pushed
the
try/fix-gray-gap
branch
from
e193d4c to
d980a03
Compare
Contributor
Author
|
I can't get the tests to pass, I keep getting this: |
Member
|
Ah, seems to be legitimate. I'll have a look now to see if I can fix it. |
Member
|
@jasmussen It seems like this is needed to expand the click redirect on an empty page: Unfortunately I'm not able to apply it correctly. Maybe I'm missing something. Here's the problem with this PR. The click redirect div somehow needs to expand to the bottom.
|
Contributor
Author
|
I believe #27253 addressed the same issue this PR intended to fix, but is better, so I'm closing this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27157.
Props @tellthemachines for suggested fix in #27157 (comment).
Before there was a gray gap when you scrolled down to the bottom of the page. This PR fixes that: