Refactor click redirect (and avoid div) #27253
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the click redirect?
It's a trailing div element behind the content.
40vhso the typewriter effect can scroll the page if the caret is at the end of the page.The
40vhpadding can be done with... just padding. :)The click redirect also doesn't really need a div. We can capture clicks directly on the canvas element.
It not only removed a useless div, we'll find later on that this div will be in the way when iframing the content. The div would have to be in the iframe with the content, which should be avoided as anything that isn't content should. Trailing divs could interfere with CSS rules.
Fixes #27157.
How has this been tested?
Screenshots
Types of changes
Checklist: