Skip to content

Refactor click redirect (and avoid div) #27253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ellatrix merged 5 commits into from
Nov 25, 2020
Merged

Refactor click redirect (and avoid div) #27253

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5764d45
Refactor click redirect(and avoid div)
ellatrix Nov 24, 2020
20f92db
Remove padding if there are meta boxes
ellatrix Nov 24, 2020
fb5e7d8
Polish
ellatrix Nov 24, 2020
360e22a
Use mouse down
ellatrix Nov 25, 2020
dfe5122
Add comment
ellatrix Nov 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use mouse down
  • Loading branch information
@ellatrix
ellatrix committed Nov 25, 2020
commit 360e22a6d9447854e1647b0c7cb25a299362bb30
9 changes: 5 additions & 4 deletions packages/block-editor/src/components/use-canvas-click-redirect/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ const isTabbableTextField = overEvery( [

export function useCanvasClickRedirect( ref ) {
useEffect( () => {
function onClick( event ) {
// Only handle clicks directly on the canvas itself, not on content.
function onMouseDown( event ) {
// Only handle clicks on the canvas, not the content.
if ( event.target !== ref.current ) {
return;
}
Expand All @@ -38,12 +38,13 @@ export function useCanvasClickRedirect( ref ) {
}

placeCaretAtHorizontalEdge( target, true );
event.preventDefault();
}

ref.current.addEventListener( 'click', onClick );
ref.current.addEventListener( 'mousedown', onMouseDown );

return () => {
ref.current.removeEventListener( 'click', onClick );
ref.current.addEventListener( 'mousedown', onMouseDown );
};
}, [] );
}