Update function name from "featuredImageIdChange" to "featuredImageId…

…Current" With this commit, I'm updating a function's name from "featuredImageIdChange" to "featuredImageIdCurrent" in order to more accurately reflect its purpose.
WordPress · SiobhyB · Feb 8, 2021 · Feb 11, 2021 · Feb 12, 2021 · Feb 12, 2021
commit 64b1c8bafa0bde962b37dd28ae6fdad2097087ac
diff --git a/packages/block-library/src/image/edit.native.js b/packages/block-library/src/image/edit.native.js
@@ -16,7 +16,7 @@ import {
 	requestImageFullscreenPreview,
 	setFeaturedImage,
 	getFeaturedImageId,
-	subscribeFeaturedImageIdChange,
+	subscribeFeaturedImageIdCurrent,
 } from '@wordpress/react-native-bridge';
 import {
 	CycleSelectControl,
@@ -87,7 +87,7 @@ export class ImageEdit extends Component {
 			this
 		);
 		this.updateMediaProgress = this.updateMediaProgress.bind( this );
-		this.featuredImageIdChange = this.featuredImageIdChange.bind( this );
+		this.featuredImageIdCurrent = this.featuredImageIdCurrent.bind( this );
 		this.updateAlt = this.updateAlt.bind( this );
 		this.updateImageURL = this.updateImageURL.bind( this );
 		this.onSetLinkDestination = this.onSetLinkDestination.bind( this );
@@ -192,7 +192,7 @@ export class ImageEdit extends Component {
 		}
 	}
 
-	featuredImageIdChange( payload ) {
+	featuredImageIdCurrent( payload ) {
 		const { attributes } = this.props;
 
 		const featuredImageId = payload.featuredImageId;
@@ -210,19 +210,19 @@ export class ImageEdit extends Component {
 
 	addFeaturedImageIdListener() {
 		//if we already have a subscription not worth doing it again
-		if ( this.subscriptionParentFeaturedImageIdChange ) {
+		if ( this.subscriptionParentFeaturedImageIdCurrent ) {
 			return;
 		}
-		this.subscriptionParentFeaturedImageIdChange = subscribeFeaturedImageIdChange(
+		this.subscriptionParentFeaturedImageIdCurrent = subscribeFeaturedImageIdCurrent(
 			( payload ) => {
-				this.featuredImageIdChange( payload );
+				this.featuredImageIdCurrent( payload );
 			}
 		);
 	}
 
 	removeFeaturedImageIdListener() {
-		if ( this.subscriptionParentFeaturedImageIdChange ) {
-			this.subscriptionParentFeaturedImageIdChange.remove();
+		if ( this.subscriptionParentFeaturedImageIdCurrent ) {
+			this.subscriptionParentFeaturedImageIdCurrent.remove();
 		}
 	}
 

diff --git a/...bridge/android/src/main/java/org/wordpress/mobile/WPAndroidGlue/DeferredEventEmitter.java b/...bridge/android/src/main/java/org/wordpress/mobile/WPAndroidGlue/DeferredEventEmitter.java
@@ -43,7 +43,7 @@ public interface JSEventEmitter {
     private static final String EVENT_NAME_MEDIA_SAVE = "mediaSave";
     private static final String EVENT_NAME_MEDIA_REPLACE_BLOCK = "replaceBlock";
 
-    private static final String EVENT_FEATURED_IMAGE_ID = "featuredImageIdChange";
+    private static final String EVENT_FEATURED_IMAGE_ID_CURRENT = "featuredImageIdCurrent";
 
     private static final String MAP_KEY_MEDIA_FILE_STATE = "state";
     private static final String MAP_KEY_MEDIA_FILE_MEDIA_ACTION_PROGRESS = "progress";
@@ -213,7 +213,7 @@ public void onMediaCollectionSaveResult(String firstMediaIdInCollection, boolean
     public void featuredImageIdNotifier(int mediaId) {
 featuredImageIdCurrent( payload ) { 
 	const { attributes } = this.props; 
 	const featuredImageId = payload.featuredImageId; 
 	if ( featuredImageId === attributes.id ) { 
 		this.setState( { 
 			isFeaturedImage: true, 
 		} ); 
 	} else { 
 		this.setState( { 
 			isFeaturedImage: false, 
 		} ); 
 	} 
 } 
 featuredImageIdCurrent( payload ) { 
 	const { attributes } = this.props; 
  
 	const featuredImageId = payload.featuredImageId; 
  
 	if ( featuredImageId === attributes.id ) { 
 		this.setState( { 
 			isFeaturedImage: true, 
 		} ); 
 	} else { 
 		this.setState( { 
 			isFeaturedImage: false, 
 		} ); 
 	} 
 } 
         WritableMap writableMap = new WritableNativeMap();
         writableMap.putInt(MAP_KEY_FEATURED_IMAGE_ID, mediaId);
-        queueActionToJS(EVENT_FEATURED_IMAGE_ID, writableMap);
+        queueActionToJS(EVENT_FEATURED_IMAGE_ID_CURRENT, writableMap);
     }
 
     @Override public void onReplaceMediaFilesEditedBlock(String mediaFiles, String blockId) {

diff --git a/packages/react-native-bridge/index.js b/packages/react-native-bridge/index.js
@@ -67,9 +67,9 @@ export function subscribeUpdateHtml( callback ) {
 	return gutenbergBridgeEvents.addListener( 'updateHtml', callback );
 }
 
-export function subscribeFeaturedImageIdChange( callback ) {
+export function subscribeFeaturedImageIdCurrent( callback ) {
 	return gutenbergBridgeEvents.addListener(
-		'featuredImageIdChange',
+		'featuredImageIdCurrent',
 		callback
 	);
 }

diff --git a/test/native/setup.js b/test/native/setup.js
@@ -21,7 +21,7 @@ jest.mock( '@wordpress/react-native-bridge', () => {
 		subscribeSetTitle: jest.fn(),
 		subscribeSetFocusOnTitle: jest.fn(),
 		subscribeUpdateHtml: jest.fn(),
-		subscribeFeaturedImageIdChange: jest.fn(),
+		subscribeFeaturedImageIdCurrent: jest.fn(),
 		subscribeMediaAppend: jest.fn(),
 		subscribeAndroidModalClosed: jest.fn(),
 		subscribeUpdateTheme: jest.fn(),