Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
a4a52fe
Add "set as featured image" button to image block
SiobhyB Feb 8, 2021
4040201
Add "setFeaturedImage" function in bridge code
SiobhyB Feb 11, 2021
6bcfbd9
Add setFeaturedImage function to MainApplication
SiobhyB Feb 12, 2021
0cff0d7
Add "OnSetFeaturedImageListener" listener
SiobhyB Feb 12, 2021
dbec57d
Update edit.native.js with small syntax correction
SiobhyB Feb 12, 2021
d66bd01
Set up "OnSetFeaturedImageListener" in WPAndroidGlue.java
SiobhyB Feb 12, 2021
d1ed155
Passing featured image ID from native (Android) to Gutenberg
SiobhyB Mar 3, 2021
6a57885
Merge branch 'trunk' into update/featured-image-button-in-image-block…
SiobhyB Mar 3, 2021
444f3e3
Restore missing curly brace
SiobhyB Mar 3, 2021
2cbe570
Updates to featured-banner.native.js
SiobhyB Mar 5, 2021
073fa92
Attempts to select featured image using getEditedPostAttribute()
SiobhyB Mar 15, 2021
64359b1
Update featured-banner.native.js
SiobhyB Mar 15, 2021
48f8ea1
Add featured banner to image/index.native.js
SiobhyB Mar 15, 2021
f114ade
Update featured image banner and button styles
SiobhyB Mar 15, 2021
46ba7e8
Create getFeaturedImageId function and cleanup
SiobhyB Mar 16, 2021
b8f05f4
Tidy up edit.native.js
SiobhyB Mar 16, 2021
c7d00f3
Update AndroidGlueCode
SiobhyB Mar 18, 2021
84a8850
retrigger checks
SiobhyB Mar 22, 2021
eb78dc4
Update setup.js
SiobhyB Mar 22, 2021
bed517e
retrigger checks
SiobhyB Mar 22, 2021
64b1c8b
Update function name from "featuredImageIdChange" to "featuredImageId…
SiobhyB Mar 23, 2021
d8c0824
Rename "featuredImageIdNotifier" to "onRequestFeaturedImageId"
SiobhyB Mar 23, 2021
32f134d
Create OnSetFeaturedImageListener
SiobhyB Mar 23, 2021
75de59f
Dismiss bottomsheet when "setFeaturedImage" is called
SiobhyB Mar 23, 2021
67369d3
Introduce "onRemoveFeatured" button and tidying up names
SiobhyB Mar 29, 2021
c9aba0a
Updates to function names
SiobhyB Mar 29, 2021
a9d051f
Convert FeaturedBanner to Badge component
SiobhyB Mar 30, 2021
a92525b
Update edit.native.js to correct merge conflict
SiobhyB Mar 30, 2021
54a5f14
Correct merge conflict with GutenbergBridgeJS2Parent.java
SiobhyB Mar 30, 2021
e99999c
retrigger checks
SiobhyB Mar 30, 2021
be31d63
retrigger checks
SiobhyB Mar 30, 2021
9795874
retrigger checks
SiobhyB Mar 30, 2021
2284524
retrigger checks
SiobhyB Mar 30, 2021
2736f33
Update edit.native.js to fix merge conflict
SiobhyB Mar 31, 2021
e9ebc69
Update edit.native.js to check if an image is featured uppn changes
SiobhyB Mar 31, 2021
2eb1979
Update styles.native.scss to add border to the top of featured button
SiobhyB Apr 1, 2021
a33b8b9
Update edit.native.js
SiobhyB Apr 1, 2021
0cdeadb
Introduce "featuredMedia" prop for use when editor loads
SiobhyB Apr 6, 2021
737627d
Fetch ID of post's initial featured image
SiobhyB Apr 7, 2021
9e524ea
Merge branch 'trunk' into update/featured-image-button-in-image-block…
SiobhyB Apr 8, 2021
6d53341
Updated featured state when image is replaced within block
SiobhyB Apr 8, 2021
cc00dc2
Remove checkIfFeaturedImage function
SiobhyB Apr 8, 2021
4dc6cef
Fix merge conflict
SiobhyB Apr 8, 2021
b335086
Fix merge conflict
SiobhyB Apr 8, 2021
3cbe30a
Add "setFeaturedImage" and "featuredImageIdCurrent" functions to Swif…
SiobhyB Apr 10, 2021
39303e4
Simplify this.state.isFeaturedImage by converting to a boolean inside…
SiobhyB Apr 10, 2021
0c69a62
Comment out iOS-specific changes to the bridge
SiobhyB Apr 12, 2021
cc4aa8d
Add iOS functions to bridge
SiobhyB Apr 12, 2021
d71d067
Flag featured image when editor mounts and comment out iOS methods fr…
SiobhyB Apr 12, 2021
28f19af
Comment out a bridge function for iOS (missing from previous commit).
SiobhyB Apr 12, 2021
262291f
Add set featured image functionality behind dev flag
SiobhyB Apr 13, 2021
a17e6e9
Move "set as featured" button behind devOnly and androidOnly flag
SiobhyB Apr 13, 2021
1c4b2ca
Calling "__DEV__" directly instead of defining a separate variable
SiobhyB Apr 13, 2021
ba7c283
Update changelog.md
SiobhyB Apr 13, 2021
206fede
Merge branch 'trunk' into update/featured-image-button-in-image-block…
SiobhyB Apr 13, 2021
1f844b6
Merge branch 'trunk' into update/featured-image-button-in-image-block…
SiobhyB Apr 20, 2021
9761c04
Merge branch 'trunk' into update/featured-image-button-in-image-block…
SiobhyB Apr 20, 2021
85844e4
Remove "subscribeFeaturedImageIdCurrent" functionality
SiobhyB Apr 20, 2021
1f61eb8
Remove featuredImageId check in componentDidMount()
SiobhyB Apr 20, 2021
35fa071
Remove isFeaturedImage functionality from image/index.native.js
SiobhyB Apr 20, 2021
590040b
Remove iOS functions from bridge
SiobhyB Apr 20, 2021
619f4f7
Remove android.util.Log import
SiobhyB Apr 20, 2021
dd6a63f
Remove redundant space
SiobhyB Apr 20, 2021
35f7023
Update CHANGELOG.md
SiobhyB Apr 20, 2021
2ed72bf
Tweak androidOnly const
SiobhyB Apr 20, 2021
c74e737
Merge branch 'trunk' into update/featured-image-button-in-image-block…
SiobhyB Apr 23, 2021
68ef75e
Refactor 'set as featured' button into its own function
SiobhyB Apr 27, 2021
fbe83c2
Merge branch 'update/featured-image-button-in-image-block-settings' o…
SiobhyB Apr 27, 2021
e3ba262
Merge branch 'trunk' into update/featured-image-button-in-image-block…
SiobhyB Apr 27, 2021
9caa86a
Fix syntax issue with onSetFeatured function
SiobhyB Apr 27, 2021
fe2c108
Merge remote-tracking branch 'upstream/trunk' into update/featured-im…
SiobhyB Apr 27, 2021
89a8c6c
Merge branch 'WordPress:trunk' into update/featured-image-button-in-i…
SiobhyB May 9, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove checkIfFeaturedImage function
This function has been replaced with functionality to grab a post's initial ID, as can be seen in the previous couple of commits.
  • Loading branch information
SiobhyB committed Apr 8, 2021
commit cc00dc22609d6e41dd004ff2b61cef90ad0586e8
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,6 @@ public static MediaType getEnum(String value) {

void setFeaturedImage(int mediaId);

void checkIfFeaturedImage(int mediaId);

void editorDidEmitLog(String message, LogLevel logLevel);

void editorDidAutosave();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -232,11 +232,6 @@ public void setFeaturedImage(final int mediaId) {
mGutenbergBridgeJS2Parent.setFeaturedImage(mediaId);
}

@ReactMethod
public void checkIfFeaturedImage(final int mediaId) {
mGutenbergBridgeJS2Parent.checkIfFeaturedImage(mediaId);
}

@ReactMethod
public void requestImageFullscreenPreview(String mediaUrl) {
mGutenbergBridgeJS2Parent.requestImageFullscreenPreview(mediaUrl);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ public interface OnReattachMediaSavingQueryListener {

public interface OnSetFeaturedImageListener {
void onSetFeaturedImageButtonClicked(int mediaId);
void checkIfFeaturedImage(int mediaId);
}

public interface OnEditorMountListener {
Expand Down Expand Up @@ -328,11 +327,6 @@ public void setFeaturedImage(int mediaId) {
mOnSetFeaturedImageListener.onSetFeaturedImageButtonClicked(mediaId);
}

@Override
public void checkIfFeaturedImage(int mediaId) {
mOnSetFeaturedImageListener.checkIfFeaturedImage(mediaId);
}

@Override
public void editorDidMount(ReadableArray unsupportedBlockNames) {
mOnEditorMountListener.onEditorDidMount(unsupportedBlockNames.toArrayList());
Expand Down
4 changes: 0 additions & 4 deletions packages/react-native-bridge/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -248,10 +248,6 @@ export function setFeaturedImage( mediaId ) {
return RNReactNativeGutenbergBridge.setFeaturedImage( mediaId );
}

export function checkIfFeaturedImage( mediaId ) {
return RNReactNativeGutenbergBridge.checkIfFeaturedImage( mediaId );
}

export function getOtherMediaOptions( filter, callback ) {
return RNReactNativeGutenbergBridge.getOtherMediaOptions(
filter,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,6 @@ public void requestImageUploadCancel(int mediaId) {
public void setFeaturedImage(int mediaId) {
}

@Override
public void checkIfFeaturedImage(int mediaId) {
}

@Override
public void editorDidMount(ReadableArray unsupportedBlockNames) {
}
Expand Down