[RNMobile] Underline selected text as soon as LinkTo field is populated #29035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewalczak
force-pushed
the
rnmobile/uderline-linked-selected-text
branch
from
24320e0 to
3393be5
Compare
lukewalczak
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.38 MB ℹ️ View Unchanged
|
2 tasks
chipsnyder
approved these changes
Feb 16, 2021
Contributor
chipsnyder
left a comment
chipsnyder
left a comment
There was a problem hiding this comment.
This looks good to me and is working as expected 👍
dratwas
approved these changes
Feb 17, 2021
Contributor
dratwas
left a comment
dratwas
left a comment
There was a problem hiding this comment.
Tested on both platforms and everything works as expected. Good job @lukewalczak
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: wordpress-mobile/gutenberg-mobile#3058
Ref to gb-mobile: wordpress-mobile/gutenberg-mobile#3156
Description
PR introduces the feature to underline the selected text as soon as
Link Tofield is populated and clean once it's empty.How has this been tested?
Details
Paragraphgoogle.comExpect selected text is underlined
Details
ApplyExpect text isn't underlined
Details
Paragraphgoogle.comExpect selected text is underlined
Remove linkExpect text isn't underlined
Details
Paragraphgoogle.comGoogleExpect selected text is underlined
Details
Expect link is autopopulated and selected text is underlined
Screenshots
Attached above
Types of changes
Feature
Checklist: