Release 1.48.0 #3205

enejb · 2021-03-01T18:25:07Z

Release for Gutenberg Mobile 1.48.0

Related PRs

Gutenberg: Mobile Release v1.48.0 WordPress/gutenberg#29445
WPAndroid: Integrate gutenberg-mobile release 1.48.0 WordPress-Android#14166
WPiOS: Integrate gutenberg-mobile release 1.48.0 WordPress-iOS#15993
~~Aztec-iOS: https://github.com/wordpress-mobile/AztecEditor-iOS/pull/~~
~~Aztec-Android: https://github.com/wordpress-mobile/AztecEditor-Android/pull~~

Extra PRs that Landed After the Release Was Cut

None

Changes

Fix crash when Column block width attribute was empty.
[RNMobile] Ignore column width attribute when empty WordPress/gutenberg#29015
Fixes crash when selecting a gradient style Fixes crash when selecting a gradient style #3166
[RNMobile] Fixes crash when selecting a gradient style WordPress/gutenberg#29072
Add audio block to initial html Add audio block to initial html #3168
[RNMobile] Added Audio block to the initial html WordPress/gutenberg#29056
Enable default keyboard as default on link picker text fields Enable default keyboard as default on link picker text fields #3170
[RnMobile] Enable default keyboard as default on link picker text fields WordPress/gutenberg#29087
Underline selected text when populating link Underline selected text when populating link #3156
[RNMobile] Underline selected text as soon as LinkTo field is populated WordPress/gutenberg#29035
Search Block 1: Add block to inserter (in dev mode) Search Block 1: Add block to inserter #3142
[RNMobile] Search Block - Add to inserter WordPress/gutenberg#28983
Make RNMobile Appium logs available Make RNMobile Appium logs available #3178
Make RNMobile Appium logs available WordPress/gutenberg#29113
Search Block 2: Add block toolbar options Search Block 2: Add block toolbar options #3182
[RNMobile] Search Block: Add block toolbar options WordPress/gutenberg#28985
Add audio block to initial html Add audio block to initial html #3168
[RNMobile] Added Audio block to the initial html WordPress/gutenberg#29056
Add typescript package v 4.1.3
Add typescript package v 4.1.3 #3200
Integrate AztecEditor-iOS 1.19.4 Integrate AztecEditor-iOS 1.19.4 #3187
Integrate AztecEditor-iOS 1.19.4 WordPress/gutenberg#29355
Add Button width attribute control
RN: Add Bottom Sheet Select Control component WordPress/gutenberg#28543

Test plan

Use the main WP apps to test the changes above.
Smoke test the main WP apps for general writing flow.

Notes

The following PR change was reverted on this branch:

Rich text: keep block ID on split

Release Submission Checklist

Approve and run optional Android and iOS UI tests
Check if RELEASE-NOTES.txt and gutenberg/packages/react-native-editor/CHANGELOG.md are updated with all the changes that made it to the release.
Bundle package of the release is updated.

…dth-attribute Ignore column width attribute when empty

* Updates gutenberg ref

* Enable default keyboard as default on link picker text fields * Update Lock file * Update Gutenberg for merged PR * Revert to develop package-lock.json

* Update ref to branch: rnmobile/uderline-linked-selected-text * Update Gutenberg Ref Co-authored-by: Chip Snyder <[email protected]>

Search Block 1: Add block to inserter

Make RNMobile Appium logs available

…e into merge_release_1.47.0_to_develop

…o_develop Merge release 1.47.0 to develop

Search Block 2: Add block toolbar options

…-initial-html Add audio block to initial html

…ence-to-master Update Gutenberg reference to point merge commit in master

Add typescript package v 4.1.3

chipsnyder · 2021-03-04T14:07:08Z

RE: #3205 (comment)

It is a theme problem. In the theme_supports
the editor-color-palette is #fcfcfc (white) for 4/5 of the colors and the gradients are all a variation of:
linear-gradient(to bottom right, #fcfcfc 49.9%, #fcfcfc 50%) or white to white.

cc @geriux

geriux · 2021-03-04T14:10:30Z

RE: #3205 (comment)

It is a theme problem. In the theme_supports
the editor-color-palette is #fcfcfc (white) for 4/5 of the colors and the gradients are all a variation of:
linear-gradient(to bottom right, #fcfcfc 49.9%, #fcfcfc 50%) or white to white.

cc @geriux

Thanks for the confirmation @chipsnyder!

geriux · 2021-03-04T15:06:37Z

geriux · 2021-03-04T15:07:33Z

geriux · 2021-03-04T16:31:53Z

Update

🟢 Writing flow tests on Android passed
🟢 Writing flow tests on iOS passed
🟢 Test Suite 1 (Android) sanity test passed
🟡 Test Suite -1 (iOS) (pending reply from this comment)
🟡 Story block - 1 (Android) (pending reply from this comment)
🟢 Test Suite -2 (iOS) sanity test passed
🟢 Test Suite 4 (iOS) sanity test passed

mchowning · 2021-03-04T16:33:26Z

🟡 TC005 - Story block - Close/Re-open post with an ongoing Story upload

I'm getting crashes on the Android activity when leaving with an ongoing upload.
This seems to be related to the deliberate decision here but this only crashes on debug builds. @mchowning I was getting the crash consistently if that helps to track down the original issue.

@chipsnyder @mchowning is this a blocker for the release? Is it the same behavior we have now on production or is this a regression that we should check?

I don't think this is a release blocker. Worst case scenario, autosave isn't working, but the changes will still be saved on exit (that's what happens instead of the crash on release builds).

UPDATE: Let's test this on a release build to make sure everything looks ok there.

enejb · 2021-03-04T18:15:28Z

@geriux
🟡 Test Suite -1 (iOS) This seems to be present currently.
I am not seeing the left and right arrows on the views that see

But this doesn't seem to be a regression since it is already present in the current app. Since the user is still able to switch columns around when they turn the app vertically I would say we can fix this in a new release.

I created a new issue for it WordPress/gutenberg#29570

enejb · 2021-03-04T22:16:03Z

geriux · 2021-03-05T08:55:47Z

@geriux
🟡 Test Suite -1 (iOS) This seems to be present currently.
I am not seeing the left and right arrows on the views that see

I see it now @enejb, since there's no much space for the arrows controls we put them under the three dots button:

For larger screens like an iPad with a Columns block with full-width alignment you'll be able to see them:

geriux · 2021-03-05T08:57:07Z

🔴 Story block - Verify is available in Block Picker - TC001 - I don't see the story block in the list of blocks.

@enejb can you confirm you were testing on iOS? If so, this block is still not out for production.

geriux · 2021-03-05T08:58:00Z

🔴 Cover - Add Video Background from WordPress Media library - TC005
When I add a video background and then preview the post I end up with a broken cover block.

@enejb This is a premium block for videos, were you testing on a paid plan?

bundle/ios/GutenbergNativeTranslations.swift

antonis · 2021-03-05T13:39:29Z

fluiddot · 2021-03-05T14:47:48Z

enejb · 2021-03-05T16:09:17Z

@geriux

can you confirm you were testing on iOS? If so, this block is still not out for production.
Yes I was testing on iOS. So I guess this is expected then.

This is a premium block for videos, were you testing on a paid plan?
Yes I was using on a simple site. I think this might not be a blocker for merging. Mostly since it doesn't
But it would be good to see if can get this fixed in the near future.

geriux · 2021-03-05T16:26:55Z

🟢 All issues have been solved, this is ready to

geriux

LGTM! Thank you to everyone involve in testing this release!

fluiddot · 2021-03-10T11:15:49Z

🔴 Story block - Verify is available in Block Picker - TC001 - I don't see the story block in the list of blocks.

@enejb can you confirm you were testing on iOS? If so, this block is still not out for production.

👋 I was testing the 1.48.1 betafix on iOS and the Story block is available in the inserter menu, I'm not sure if that changed recently 🤔 .

In fact I tested a bit that block and I found some issues (you can check them in this comment), one of them produce a crash so probably we should review them and potentially make another betafix. What do you think?

@enejb @geriux

Paul Von Schrottky and others added 30 commits February 15, 2021 21:53

Update gutenberg submodule ref

f8687f8

Update gutenberg submodule ref

9f5e050

Update release notes

e93f80b

Update gutenberg submodule ref

44626fb

Merge branch 'develop' into ignore-empty-column-width-attribute

6505547

Merge pull request #3151 from wordpress-mobile/ignore-empty-column-wi…

be938b8

…dth-attribute Ignore column width attribute when empty

Fixes crash when selecting a gradient style (#3166)

36d92f8

* Updates gutenberg ref

updated gutenberg ref.

b00a576

updated gutenberg ref.

63d7270

Enable default keyboard as default on link picker text fields (#3170)

3965e70

* Enable default keyboard as default on link picker text fields * Update Lock file * Update Gutenberg for merged PR * Revert to develop package-lock.json

Underline selected text when populating link (#3156)

098b2bb

* Update ref to branch: rnmobile/uderline-linked-selected-text * Update Gutenberg Ref Co-authored-by: Chip Snyder <[email protected]>

updated gutenberg reference for Search Block merge

0ed1c4f

Merge pull request #3142 from wordpress-mobile/add/search-block-1

bc38edb

Search Block 1: Add block to inserter

Update submodule ref

e45cc62

Update gutenberg submodule ref

88c12fa

Merge pull request #3178 from wordpress-mobile/make-appium-log-available

2e14365

Make RNMobile Appium logs available

Merge branch 'develop' of github.com:wordpress-mobile/gutenberg-mobil…

4337773

…e into merge_release_1.47.0_to_develop

Merge pull request #3181 from wordpress-mobile/merge_release_1.47.0_t…

3bb1f9c

…o_develop Merge release 1.47.0 to develop

Update reference to gutenberg to include search block toolbar

cf72cf9

Merge branch 'develop' into fix/add-audio-block-to-initial-html

90e96e4

Merge pull request #3182 from wordpress-mobile/add/search-block-toolbar

cf3ab96

Search Block 2: Add block toolbar options

Merge branch 'develop' into fix/add-audio-block-to-initial-html

9dbdc51

Merge pull request #3168 from wordpress-mobile/fix/add-audio-block-to…

daba192

…-initial-html Add audio block to initial html

Update Gutenberg reference to point merge commit in master

609feed

Merge pull request #3195 from wordpress-mobile/update/gutenberg-refer…

60aa0e8

…ence-to-master Update Gutenberg reference to point merge commit in master

Add typescript package v 4.1.3

41d76ad

Merge pull request #3200 from wordpress-mobile/add/typescript-linter

acf7609

Add typescript package v 4.1.3

Integrate iOS Aztec 1.19.4

3fea80d

Update gutenberg ref

f07fb16

Generate bundle

a14019a

Gerardo Pacheco added 5 commits March 5, 2021 10:14

Update Gutenberg ref

d71b082

Update Release notes

ec9e51c

Update makepot command to exclude e2e-tests strings

011786e

Update strings

ce8ae1e

Update typo in Release notes

3615a7a

hound bot reviewed Mar 5, 2021

View reviewed changes

bundle/ios/GutenbergNativeTranslations.swift Show resolved Hide resolved

mchowning mentioned this pull request Mar 5, 2021

Mobile: Columns Block: Missing move arrows on iPhone 11 when you have more then 2 columns. WordPress/gutenberg#29570

Closed

Gerardo Pacheco added 2 commits March 5, 2021 14:04

Update Gutenberg ref

f3bc9ab

Update bundles

614d72d

geriux approved these changes Mar 5, 2021

View reviewed changes

enejb merged commit 12d7b2c into trunk Mar 5, 2021

enejb deleted the release/1.48.0 branch March 5, 2021 16:37

fluiddot restored the release/1.48.0 branch March 9, 2021 15:22

fluiddot deleted the release/1.48.0 branch March 9, 2021 15:50

Release 1.48.0 #3205

Release 1.48.0 #3205

Uh oh!

Conversation

enejb commented Mar 1, 2021 • edited by geriux Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related PRs

Extra PRs that Landed After the Release Was Cut

Changes

Test plan

Notes

Release Submission Checklist

Uh oh!

chipsnyder commented Mar 4, 2021

Uh oh!

geriux commented Mar 4, 2021

Uh oh!

geriux commented Mar 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android Writing Flow checklist (round 2)

General

Rich Text Format

Splitting and merging

Undo / Redo - Test Cases

Uh oh!

geriux commented Mar 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS Writing Flow checklist

Writing Flow checklist

General

Rich Text Format

Splitting and merging

Undo / Redo - Test Cases

Uh oh!

geriux commented Mar 4, 2021

Update

Uh oh!

mchowning commented Mar 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

enejb commented Mar 4, 2021

Uh oh!

enejb commented Mar 4, 2021

Gallery - 2

Gallery - 3

Gallery - 4

MediaText - 3

MediaText - 4

Cover - 2

Social Icons - 2

Image - 2

Story block - 1

Uh oh!

geriux commented Mar 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

geriux commented Mar 5, 2021

Uh oh!

geriux commented Mar 5, 2021

Uh oh!

Uh oh!

antonis commented Mar 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Writing Flow checklist

General

Rich Text Format

Splitting and merging

Undo / Redo - Test Cases

Uh oh!

fluiddot commented Mar 5, 2021

iOS Writing Flow checklist

Writing Flow checklist

General

Rich Text Format

Splitting and merging

Undo / Redo - Test Cases

Uh oh!

enejb commented Mar 5, 2021

Uh oh!

geriux commented Mar 5, 2021

enejb commented Mar 1, 2021 •

edited by geriux

Loading

geriux commented Mar 4, 2021 •

edited

Loading

geriux commented Mar 4, 2021 •

edited

Loading

mchowning commented Mar 4, 2021 •

edited

Loading

geriux commented Mar 5, 2021 •

edited

Loading

antonis commented Mar 5, 2021 •

edited

Loading