Add enableCustomSpacing to block editor settings #29277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the Spacing control not appearing when global styles are disabled and enableCustomSpacing is set to true in the post editor settings.
noisysocks
added
[Type] Bug
noisysocks
commented
Feb 23, 2021
|
|
||
| return useMemo( | ||
| () => ( { | ||
| ...pick( settings, [ |
Member
Author
There was a problem hiding this comment.
Using pick here is error prone as, when one adds a new editor setting, one has to also remember to add the setting name here. I wonder if flipping this to be omit would be better?
Member
There was a problem hiding this comment.
Thanks, @noisysocks
I was getting desperate and then came across your comment.
Maybe we should document this for other contributors. Or use pick( settings, Object.keys( SETTINGS_DEFAULTS ) ).
noisysocks
commented
Feb 23, 2021
| 'disableCustomGradients', | ||
| 'enableCustomUnits', | ||
| 'enableCustomLineHeight', | ||
| 'enableCustomSpacing', |
|
Size Change: +10 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
Contributor
|
The PR works well for me. |
Contributor
|
Will this make it into WP 5.7 RC 2? I can't see the fix in the nightlies. |
Member
Author
Yes I'll commit it to Core shortly. |
noisysocks
added a commit
that referenced
this pull request
Mar 1, 2021
This fixes the Spacing control not appearing when global styles are disabled and enableCustomSpacing is set to true in the post editor settings.
noisysocks
removed
the
Backport to WP 6.9 Beta/RC
noisysocks
added a commit
that referenced
this pull request
Mar 1, 2021
This fixes the Spacing control not appearing when global styles are disabled and enableCustomSpacing is set to true in the post editor settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://core.trac.wordpress.org/ticket/52619.
This fixes the Spacing control not appearing when global styles are disabled and
enableCustomSpacingis set totruein the post editor settings. This means that the Spacing control will appear in Core when the theme hasadd_theme_support( 'custom-spacing' );.How has this been tested?
Ensure that you are testing Gutenberg against WordPress 5.7 RC 1 or against the latest Core
trunk. This is the default Gutenberg dev environment setup.Ensure that you are using a theme with
add_theme_support( 'custom-spacing' );e.g. Twenty Twenty-one.Simulate Core and disable global styles by commenting out this line in
lib/global-styles.php:Insert a Cover block.
The Spacing panel should appear in the block inspector.