Skip to content

Add enableCustomSpacing to block editor settings #29277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noisysocks merged 1 commit into from
Mar 1, 2021
Merged

Add enableCustomSpacing to block editor settings #29277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/editor/src/components/provider/use-block-editor-settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ function useBlockEditorSettings( settings, hasTemplate ) {

return {
canUseUnfilteredHTML: canUserUseUnfilteredHTML(),
reusableBlocks: select( 'core' ).getEntityRecords(
reusableBlocks: select( coreStore ).getEntityRecords(
'postType',
'wp_block',
/**
Expand All @@ -151,11 +151,11 @@ function useBlockEditorSettings( settings, hasTemplate ) {
() => ( {
...pick( settings, [
Copy link
Member Author

@noisysocks noisysocks Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using pick here is error prone as, when one adds a new editor setting, one has to also remember to add the setting name here. I wonder if flipping this to be omit would be better?

Copy link
Member

@Mamaduka Mamaduka Mar 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @noisysocks

I was getting desperate and then came across your comment.

Maybe we should document this for other contributors. Or use pick( settings, Object.keys( SETTINGS_DEFAULTS ) ).

'__experimentalBlockDirectory',
'__experimentalBlockPatterns',
'__experimentalBlockPatternCategories',
'__experimentalBlockPatterns',
'__experimentalFeatures',
'__experimentalGlobalStylesUserEntityId',
'__experimentalGlobalStylesBaseStyles',
'__experimentalGlobalStylesUserEntityId',
'__experimentalPreferredStyleVariations',
'__experimentalSetIsInserterOpened',
'alignWide',
Expand All @@ -167,16 +167,17 @@ function useBlockEditorSettings( settings, hasTemplate ) {
'disableCustomColors',
'disableCustomFontSizes',
'disableCustomGradients',
'enableCustomUnits',
'enableCustomLineHeight',
'enableCustomSpacing',
Copy link
Member Author

@noisysocks noisysocks Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fix.

'enableCustomUnits',
'focusMode',
'fontSizes',
'gradients',
'hasFixedToolbar',
'hasReducedUI',
'imageDimensions',
'imageEditing',
'imageSizes',
'imageDimensions',
'isRTL',
'keepCaretInsideBlock',
'maxWidth',
Expand Down