[RNMobile] Search Block: Styling #30052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only adds a shell of a block.
This alert will be removed once styling is added in a later PR.
This will keep the code cleaner and easier to follow.
This toolbar action is now visible in the UI so the temporary alert message is no longer needed.
Was causing issues with layout in iOS. Styling will be addressed fully in a different PR.
…-search-block-button-position
…-search-block-button-position
Moved the CSS_UNIT code to a shared Utils file in preparation for using the same code inside the native implementation of the search block.
Also moved the default values from the web version to the shared utils file.
# Conflicts: # packages/block-library/src/search/edit.native.js # packages/block-library/src/search/rich-text.android.scss # packages/block-library/src/search/rich-text.ios.scss # packages/block-library/src/search/style.native.scss
…le/3073-search-block-settings
# Conflicts: # packages/block-library/src/search/edit.native.js
- Set the onFocus() method to ensure if the placeholder text is clicked on when the block is NOT selected then the block will be selected. - Set isSelected in RichText elements to false for initial draw to prevent odd behavior on iOS where the Search block will attempt to steal focus from other text blocks. - Set the placeholder text to focused when the block is first added.
AmandaRiu
added
[Block] Search
Contributor
Author
|
cc: @iamthomasbishop (and Kylea Parker but she's not in this repo for direct pinging). |
2 tasks
|
Size Change: +10.8 kB (+1%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
Base automatically changed from
rnmobile/search-block-move-toolbar-options
to
trunk
March 19, 2021 23:48
|
Hi @AmandaRiu 👋 This is looking really good! I have a couple of questions:
|
Contributor
Author
|
@kyleaparker Thanks for the review!
Currently it just wraps in place. The changes required for moving the button below the text input are not included in this PR. I plan on handling that separately.
Yup, selection color has not been changed for this project and is just using the same colors as the rest of the blocks. |
👍
Ok sounds good, thanks for confirming! |
cameronvoell
approved these changes
Mar 23, 2021
Member
cameronvoell
left a comment
cameronvoell
left a comment
There was a problem hiding this comment.
Tested the various states in light mode and dark mode on Android and iOS and was unable to find any issues. Code updates seem consistent with other native blocks as well. Search block is looking great, nice work!
geriux
reviewed
Mar 24, 2021
Member
geriux
left a comment
geriux
left a comment
There was a problem hiding this comment.
Hey @AmandaRiu 👋
So exciting to see how far this block is getting at 👏
I just left a couple of comments suggesting a different approach to merge styles, to simplify it a bit. Let me know what you think about it! 😃
enejb
reviewed
Mar 24, 2021
Contributor
|
I did a bunch of testing of this PR on iOS and Android and it worked really well. Nice work! |
Contributor
Author
|
@geriux Thank you for the review and all the suggestions. Implemented and ready for another round! |
7 tasks
geriux
approved these changes
Mar 25, 2021
Member
geriux
left a comment
geriux
left a comment
There was a problem hiding this comment.
Nice work!!! 🎉 LGTM. Tested it on both iOS and Android.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg Mobile PR
wordpress-mobile/gutenberg-mobile#3210
Note: The PR to move toolbar options to the settings panel must be merged before this PR can be taken out of draft.Description
This PR is one in a series of PRs to port the search block to mobile. This PR implements styling from the latest i2 designs plus dark mode support:
Designs
How has this been tested?
Tested on an Android emulator and iOS simulator. Test the following states in light and dark mode:
Screenshots
Types of changes
New feature currently only available in devOnly mode. No changes were made that would effect the web-version of the search block, nor any other block.
Checklist: